chore(primary details): fix drawer and toolbar by andrew-ronaldson · Pull Request #8509 · patternfly/patternfly

andrew-ronaldson · 2026-07-20T13:45:32Z

Closes #8488
This addresses issues found in the 6.5 staging audit.

I moved the drawers below the toolbar and made them inline so they work better in glass mode.
Also changed the inset on the toolbar in some examples where it looked broken.

Summary by CodeRabbit

New Features / Improvements
- Standardized PatternFly Primary Detail drawer demos to consistently use the inline layout across expanded, collapsed, card, and mobile variants.
- Updated drawer structure so the toolbar renders in a dedicated area above the divider for clearer spacing.
- Improved toolbar customization by supporting additional toolbar attributes alongside existing ID/modifier options.
- Refined toolbar styling for relevant inline/card views (including inset presentation).
Removed
- Removed outdated Primary Detail demo template variations that no longer match the refreshed layout.

coderabbitai · 2026-07-20T13:50:22Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c50b736a-76bb-46be-91a3-7ab71d936a0d

📥 Commits

Reviewing files that changed from the base of the PR and between 4648dcf and b1a0e32.

📒 Files selected for processing (1)

src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md

💤 Files with no reviewable changes (1)

src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md

Walkthrough

Primary Detail demos now use the pf-m-inline drawer modifier, revised drawer-section and toolbar placement, and updated card-view toolbar spacing. The toolbar template forwards custom attributes, while several unused supporting templates are removed.

Changes

Primary Detail inline drawer demos

Layer / File(s)	Summary
Forward toolbar attributes `src/patternfly/demos/Toolbar/toolbar-template.hbs`	The toolbar template forwards `toolbar-template--attribute` to the underlying toolbar.
Update Primary Detail drawer variants `src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md`, `src/patternfly/demos/PrimaryDetail/primary-detail-template-card-data-list.hbs`, `src/patternfly/demos/PrimaryDetail/primary-detail-template-card-toolbar.hbs`, `src/patternfly/demos/PrimaryDetail/primary-detail-template-simple-list.hbs`	Primary Detail examples switch to inline drawer layouts, move toolbars into drawer sections, update toolbar spacing, and remove unused supporting templates.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

#7781 — Covers similar Primary Detail demo updates involving drawer restructuring, toolbar insets, and inline layout changes.

Suggested labels: released on @prerelease``

Suggested reviewers: srambach, mcoker

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is descriptive and matches the PR's focus on Primary Details drawer and toolbar updates.
Linked Issues check	✅ Passed	The changes align with [`#8488`] by updating Primary Details core demos, drawer placement, and toolbar styling.
Out of Scope Changes check	✅ Passed	No clearly unrelated changes are shown; the template removals and toolbar edits fit the Primary Details demo update.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

patternfly-build · 2026-07-20T13:50:56Z

Preview: https://pf-pr-8509.surge.sh

A11y report: https://pf-pr-8509-a11y.surge.sh

mcoker · 2026-07-20T21:15:16Z

@@ -200,7 +205,7 @@ wrapperTag: div
    {{#> card}}


Should we also remove this card? It doesn't go around the examples properly anymore. If so we would want to take "card" out of the example name.

mcoker · 2026-07-20T21:18:49Z

@@ -238,7 +243,7 @@ wrapperTag: div
    {{#> card}}


Whatcha reckon we remove this card, too?

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

removed card from mobile example

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md`:
- Line 17: Update all three primary-detail-template invocations in the demos to
restore the inline drawer configuration by passing
primary-detail-template--modifier="pf-m-inline" and drawer--IsInline="true"
alongside the existing parameters.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e1a0ca2-2487-4657-9d0c-eb27999cb32b

📥 Commits

Reviewing files that changed from the base of the PR and between 7c97586 and 4648dcf.

📒 Files selected for processing (4)

src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md
src/patternfly/demos/PrimaryDetail/primary-detail-template-card-data-list.hbs
src/patternfly/demos/PrimaryDetail/primary-detail-template-card-toolbar.hbs
src/patternfly/demos/PrimaryDetail/primary-detail-template-simple-list.hbs

💤 Files with no reviewable changes (3)

src/patternfly/demos/PrimaryDetail/primary-detail-template-simple-list.hbs
src/patternfly/demos/PrimaryDetail/primary-detail-template-card-toolbar.hbs
src/patternfly/demos/PrimaryDetail/primary-detail-template-card-data-list.hbs

coderabbitai · 2026-07-23T13:07:00Z


    <!-- Drawer -->
-    {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") primary-detail-template--modifier="pf-m-inline-on-2xl" drawer-panel--IsOpen="true"}}
+    {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") drawer-panel--IsOpen="true"}}


🎯 Functional Correctness | 🟠 Major

Restore the inline modifier in all three demos.

These invocations now omit both primary-detail-template--modifier="pf-m-inline" and drawer--IsInline. Since primary-detail-template.hbs forwards the modifier to drawer.hbs, these examples render as regular drawers rather than inline drawers, so the PR objective is not met.

Proposed fix

- {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") drawer-panel--IsOpen="true"}} + {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") primary-detail-template--modifier="pf-m-inline" drawer-panel--IsOpen="true"}} - {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer")}} + {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") primary-detail-template--modifier="pf-m-inline"}} - {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") drawer-panel--IsOpen="true"}} + {{#> primary-detail-template primary-detail-template--id=(concat page-template--id "-drawer") primary-detail-template--modifier="pf-m-inline" drawer-panel--IsOpen="true"}}

Also applies to: 68-68, 115-115

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md` at line 17, Update all three primary-detail-template invocations in the demos to restore the inline drawer configuration by passing primary-detail-template--modifier="pf-m-inline" and drawer--IsInline="true" alongside the existing parameters.

mcoker

   ----------
   | groovy |
   ----------
  / 
🎃
🎽
👖
🛼

patternfly-build · 2026-07-24T17:04:12Z

🎉 This PR is included in version 6.6.0-prerelease.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix: address word-break/overflow-wrap bug (#8487) * chore(input group): add radius modifier (#8483) * fix(table): nested table sorting (#8491) * fix(tree-view): revert caret rotations (#8490) * fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493) * fix(tree): update tree table and DLS tree toggle icon direction (#8502) * fix: update disabled description to use text color token (#8497) * fix(plain actions): update tokens to vertical-plain (#8495) * fix: address bottom pagination bugs (#8498) * fix: address bottom pagination bugs * fix: round border-radius on default bottom in glass * chore(primary details): fix drawer and toolbar (#8509) * fix(modal): footer action spacing (#8526) --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: Jake Miller <jake83miller@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Jake Miller <jakmille@redhat.com>

chore(primary details): fix drawer and toolbar

ea8c5f7

andrew-ronaldson requested a review from mcoker July 20, 2026 13:45

mcoker reviewed Jul 20, 2026

View reviewed changes

andrew-ronaldson and others added 4 commits July 21, 2026 12:52

Update src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md

9b93d15

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

Update src/patternfly/demos/PrimaryDetail/examples/PrimaryDetail.md

6f7b960

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>

chore(primary details): fix mobile demo in card

7c97586

removed card from mobile example

chore(primary details): toolbar edits and remove list example

4648dcf

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

chore(primary details): remove padding demo

b1a0e32

mcoker approved these changes Jul 24, 2026

View reviewed changes

mcoker merged commit ea02149 into patternfly:main Jul 24, 2026
6 checks passed

patternfly-build added the released on @prerelease label Jul 24, 2026

dlabaj pushed a commit that referenced this pull request Jul 28, 2026

chore(primary details): fix drawer and toolbar (#8509)

ec570f9

dlabaj mentioned this pull request Jul 28, 2026

fix: cherry-pick main fixes into 6.6.x #8531

Merged

dlabaj pushed a commit that referenced this pull request Jul 28, 2026

chore(primary details): fix drawer and toolbar (#8509)

af20db8

coderabbitai Bot mentioned this pull request Aug 4, 2026

Spike - Investigate best option for drawer #8504

Open

Navigation Menu

Uh oh!

chore(primary details): fix drawer and toolbar - #8509

chore(primary details): fix drawer and toolbar#8509
mcoker merged 6 commits into
patternfly:mainfrom
andrew-ronaldson:primary-details

andrew-ronaldson commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Reviews paused

Uh oh!

patternfly-build commented Jul 20, 2026 •

edited

Loading

Uh oh!

mcoker Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

mcoker Jul 20, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 23, 2026

Uh oh!

mcoker left a comment

Uh oh!

Uh oh!

patternfly-build commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

andrew-ronaldson commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

patternfly-build commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcoker Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcoker Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patternfly-build commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrew-ronaldson commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

patternfly-build commented Jul 20, 2026 •

edited

Loading