Skip to content

fix(table): nested table sorting - #8491

Merged
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:bug/8455-tables-nested-sorting
Jul 9, 2026
Merged

fix(table): nested table sorting#8491
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:bug/8455-tables-nested-sorting

Conversation

@jcmill

@jcmill jcmill commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes: #8485

Change :last tr pointer-events to auto to allow for click through with new background treatment.

Summary by CodeRabbit

  • Bug Fixes
    • Improved interaction for nested table column headers by enabling pointer events on the last nested header row, making it easier to interact with nested header layouts.

@jcmill
jcmill requested a review from mcoker July 9, 2026 18:31
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 274b4456-b6d5-4262-8062-3be6cc8d4ac2

📥 Commits

Reviewing files that changed from the base of the PR and between d42efe2 and 57f7ad0.

📒 Files selected for processing (1)
  • src/patternfly/components/Table/table.scss
💤 Files with no reviewable changes (1)
  • src/patternfly/components/Table/table.scss

Walkthrough

The Table SCSS changes one nested column header rule so the last non-border header row now allows pointer interactions by setting pointer-events to auto.

Changes

Table Nested Header Styling

Layer / File(s) Summary
Enable pointer events on nested header last row
src/patternfly/components/Table/table.scss
pointer-events for .pf-m-nested-column-header last row selector changes from none to auto.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mcoker

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR changes table header pointer-events, but issue #8455 requires updating dashboard status labels. Implement the status-label styling changes requested in #8455, or relink the PR if the table fix is the intended issue.
Out of Scope Changes check ⚠️ Warning The lone CSS edit is about nested table header click behavior, which is unrelated to the linked status-label objective. Remove or justify the table.scss change, and keep the PR scoped to the linked dashboard status-label work.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format and describes the table-related change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Comment thread src/patternfly/components/Table/table.scss Outdated
@jcmill jcmill changed the title change last tr pointer-events to auto for clickthrough with new backg… fix(table): nested table sorting Jul 9, 2026
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
@jcmill
jcmill requested a review from mcoker July 9, 2026 18:47

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎃

@mcoker
mcoker merged commit 1eac6d2 into patternfly:main Jul 9, 2026
6 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

dlabaj pushed a commit that referenced this pull request Jul 28, 2026
dlabaj added a commit that referenced this pull request Jul 28, 2026
* fix: address word-break/overflow-wrap bug (#8487)

* chore(input group): add radius modifier (#8483)

* fix(table): nested table sorting (#8491)

* fix(tree-view): revert caret rotations (#8490)

* fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)

* fix(tree): update tree table and DLS tree toggle icon direction (#8502)

* fix: update disabled description to use text color token (#8497)

* fix(plain actions): update tokens to vertical-plain (#8495)

* fix: address bottom pagination bugs (#8498)

* fix: address bottom pagination bugs

* fix: round border-radius on default bottom in glass

* chore(primary details): fix drawer and toolbar (#8509)

* fix(modal): footer action spacing (#8526)

---------

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
Co-authored-by: Jake Miller <jake83miller@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jake Miller <jakmille@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Table - sorting is not available for nested tables with v6.6.0

3 participants