Skip to content

fix(tree): update tree table and DLS tree toggle icon direction - #8502

Merged
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8501
Jul 16, 2026
Merged

fix(tree): update tree table and DLS tree toggle icon direction#8502
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8501

Conversation

@mcoker

@mcoker mcoker commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #8501

needed for patternfly/patternfly-react#12554

Summary by CodeRabbit

  • Bug Fixes
    • Updated Dual List Selector and table tree-view toggle icons to display the correct caret direction.
    • Improved expanded-state icon rotation for clearer visual feedback.
    • Table toggles now reflect whether items are expandable or expanded.

@mcoker
mcoker requested review from jcmill and thatblindgeye July 15, 2026 20:25
@patternfly-build

patternfly-build commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8502.surge.sh

A11y report: https://pf-pr-8502-a11y.surge.sh

@coderabbitai

coderabbitai Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updates DualListSelector and Table tree-view toggle icons to use right/down caret directions, with expanded states rotating to 90 degrees.

Changes

Tree toggle icon alignment

Layer / File(s) Summary
DualListSelector toggle orientation
src/patternfly/components/DualListSelector/...		 Uses the right caret glyph and changes the expanded-state rotation to 90deg.
Table tree-view toggle orientation
src/patternfly/components/Table/...		 Uses conditional right/down caret glyphs and adds a 90deg expanded-state rotation for tree-view toggles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • patternfly/patternfly-react#12553 — Covers the same tree-view collapsed and expanded caret direction behavior.

Possibly related PRs

Suggested reviewers: kmcfaul, srambach, thatblindgeye

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes match #8501 by updating the missed dual list selector and tree table toggle icons to right/down directions.
Out of Scope Changes check ✅ Passed All modified files are directly related to the tree toggle icon direction fix with no unrelated changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses a conventional commit prefix and accurately summarizes the toggle icon direction updates in tree table and dual list selector.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mcoker mcoker mentioned this pull request Jul 15, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jul 15, 2026
Closed
jcmill
jcmill approved these changes Jul 16, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲

@mcoker
mcoker merged commit c5e306c into patternfly:main Jul 16, 2026
6 checks passed
@mcoker
mcoker deleted the issue-8501 branch July 16, 2026 18:10
@patternfly-build

patternfly-build commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Jul 22, 2026
Closed
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@mcoker @dlabaj
fix(tree): update tree table and DLS tree toggle icon direction (#8502)
084e733
@dlabaj dlabaj mentioned this pull request Jul 28, 2026
Merged
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@mcoker @dlabaj
fix(tree): update tree table and DLS tree toggle icon direction (#8502)
69d6170
dlabaj added a commit that referenced this pull request Jul 28, 2026
@dlabaj @mcoker
@andrew-ronaldson @jcmill @thatblindgeye
fix: cherry-pick main fixes into 6.6.x (#8531)
60468ef 
* fix: address word-break/overflow-wrap bug (#8487)

* chore(input group): add radius modifier (#8483)

* fix(table): nested table sorting (#8491)

* fix(tree-view): revert caret rotations (#8490)

* fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)

* fix(tree): update tree table and DLS tree toggle icon direction (#8502)

* fix: update disabled description to use text color token (#8497)

* fix(plain actions): update tokens to vertical-plain (#8495)

* fix: address bottom pagination bugs (#8498)

* fix: address bottom pagination bugs

* fix: round border-radius on default bottom in glass

* chore(primary details): fix drawer and toolbar (#8509)

* fix(modal): footer action spacing (#8526)

---------

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
Co-authored-by: Jake Miller <jake83miller@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jake Miller <jakmille@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes
@jcmill jcmill jcmill approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Update dual list selector tree and tree table icons

4 participants

@mcoker @patternfly-build @thatblindgeye @jcmill