Skip to content

fix(tree-view): revert caret rotations - #8490

Merged
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:fix/8474-treeview-revert-carets
Jul 9, 2026
Merged

fix(tree-view): revert caret rotations#8490
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:fix/8474-treeview-revert-carets

Conversation

@jcmill

@jcmill jcmill commented Jul 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Closes: #8474

Reverted the expand/collapse pattern from down/up to right/down.

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the TreeView node toggle icon rotation to better reflect expanded vs. collapsed state.
    • Updated the TreeView toggle icon behavior so the appropriate caret direction is shown when the toggle attribute is present.

@jcmill
jcmill requested review from andrew-ronaldson and mcoker July 9, 2026 14:17
@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a1dc8ad7-bbeb-4f57-9d82-a9a7d66e01f0

📥 Commits

Reviewing files that changed from the base of the PR and between 73c5e10 and 6fa3252.

📒 Files selected for processing (2)
  • src/patternfly/components/TreeView/tree-view-node-toggle-icon.hbs
  • src/patternfly/components/TreeView/tree-view.scss

Walkthrough

TreeView toggle icons now use a right-facing caret in the template, and the expanded-state rotation in the stylesheet is updated to 90deg.

Changes

TreeView toggle icon orientation

Layer / File(s) Summary
Icon and rotation update
src/patternfly/components/TreeView/tree-view-node-toggle-icon.hbs, src/patternfly/components/TreeView/tree-view.scss		 The TreeView node toggle icon switches to rh-microns-caret-right, and the expanded-state rotation is changed to 90deg.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, srambach, mcoker

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format and accurately describes the tree view caret rotation change.
Linked Issues check ✅ Passed The changes restore tree view carets to the right/down pattern requested in #8474.
Out of Scope Changes check ✅ Passed Only tree view caret icon and rotation changes are included, matching the linked issue scope.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8490.surge.sh

A11y report: https://pf-pr-8490-a11y.surge.sh

andrew-ronaldson
andrew-ronaldson approved these changes Jul 9, 2026
View reviewed changes

@andrew-ronaldson andrew-ronaldson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

mcoker
mcoker reviewed Jul 9, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though curious if you tried updating the icon itself, too, so that the icon without rotation is pointing in the collapsed direction (right), then we rotate it 90deg for the expanded position (down). That should be how all of our other caret/expand icons are setup.

Also be sure to add the issue # to the description or link the issue to the PR so the issue closes when the PR is merged and so that it's easy to find the issue if someone lands on this PR.

@jcmill

jcmill commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Good call. Just updated the pr.

@jcmill
jcmill requested a review from mcoker July 9, 2026 18:06
mcoker
mcoker approved these changes Jul 9, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mcoker
mcoker merged commit 716f0e5 into patternfly:main Jul 9, 2026
6 checks passed
@patternfly-build

patternfly-build commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Jul 10, 2026
Closed
This was referenced Jul 15, 2026
Closed
Merged
@mcoker mcoker mentioned this pull request Jul 22, 2026
Closed
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@jcmill @dlabaj
fix(tree-view): revert caret rotations (#8490)
fdc1c4d
@dlabaj dlabaj mentioned this pull request Jul 28, 2026
Merged
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@jcmill @dlabaj
fix(tree-view): revert caret rotations (#8490)
9d0d774
dlabaj added a commit that referenced this pull request Jul 28, 2026
@dlabaj @mcoker
@andrew-ronaldson @jcmill @thatblindgeye
fix: cherry-pick main fixes into 6.6.x (#8531)
60468ef 
* fix: address word-break/overflow-wrap bug (#8487)

* chore(input group): add radius modifier (#8483)

* fix(table): nested table sorting (#8491)

* fix(tree-view): revert caret rotations (#8490)

* fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)

* fix(tree): update tree table and DLS tree toggle icon direction (#8502)

* fix: update disabled description to use text color token (#8497)

* fix(plain actions): update tokens to vertical-plain (#8495)

* fix: address bottom pagination bugs (#8498)

* fix: address bottom pagination bugs

* fix: round border-radius on default bottom in glass

* chore(primary details): fix drawer and toolbar (#8509)

* fix(modal): footer action spacing (#8526)

---------

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
Co-authored-by: Jake Miller <jake83miller@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jake Miller <jakmille@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes
@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Treeview - Revert caret back to right/down.

4 participants

@jcmill @patternfly-build @andrew-ronaldson @mcoker