fix: update disabled description to use text color token - #8497
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Menu stylesheet documents pending removal of a disabled button color variable and changes disabled item descriptions to use the disabled item color token instead of the disabled icon color token. ChangesMenu disabled colors
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8497.surge.sh A11y report: https://pf-pr-8497-a11y.surge.sh |
Collaborator
|
🎉 This PR is included in version 6.6.0-prerelease.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dlabaj
pushed a commit
that referenced
this pull request
Jul 28, 2026
dlabaj
pushed a commit
that referenced
this pull request
Jul 28, 2026
dlabaj
added a commit
that referenced
this pull request
Jul 28, 2026
* fix: address word-break/overflow-wrap bug (#8487) * chore(input group): add radius modifier (#8483) * fix(table): nested table sorting (#8491) * fix(tree-view): revert caret rotations (#8490) * fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493) * fix(tree): update tree table and DLS tree toggle icon direction (#8502) * fix: update disabled description to use text color token (#8497) * fix(plain actions): update tokens to vertical-plain (#8495) * fix: address bottom pagination bugs (#8498) * fix: address bottom pagination bugs * fix: round border-radius on default bottom in glass * chore(primary details): fix drawer and toolbar (#8509) * fix(modal): footer action spacing (#8526) --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: Jake Miller <jake83miller@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Jake Miller <jakmille@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8496
Also marks a var to remove in a breaking change since it isn't used anywhere.
Summary by CodeRabbit