Skip to content

fix(a11y): ignore target-size rule for WCAG 2.2 bump - #8493

Merged
thatblindgeye merged 1 commit into
patternfly:mainfrom
thatblindgeye:ignoreTargetSize
Jul 16, 2026
Merged

fix(a11y): ignore target-size rule for WCAG 2.2 bump#8493
thatblindgeye merged 1 commit into
patternfly:mainfrom
thatblindgeye:ignoreTargetSize

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jul 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Related to #8492. We want to temporarily ignore the target-size AA rule introduced in WCAG 2.2 until we can see whether we're able to resolve all violations (some might be false positives, however). We need to ignore the rule for now so that we can merge the a11y tool bump PR and not have every PR fail build processes.

Summary by CodeRabbit

  • Chores
    • Updated accessibility validation settings to exclude the target-size rule from reported results.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4ba01ada-1b7c-4b22-bb18-ee0b8860dcfb

📥 Commits

Reviewing files that changed from the base of the PR and between 716f0e5 and f83e427.

📒 Files selected for processing (1)
  • patternfly-a11y.config.js

Walkthrough

The accessibility configuration adds target-size to the ignored rules list while retaining aria-required-children.

Changes

Accessibility configuration

Layer / File(s) Summary
Extend ignored accessibility rules
patternfly-a11y.config.js		 Adds target-size to the exported ignoreRules array alongside aria-required-children.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format and clearly matches the accessibility rule ignore change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8493.surge.sh

A11y report: https://pf-pr-8493-a11y.surge.sh

@thatblindgeye
thatblindgeye merged commit 7b3f55e into patternfly:main Jul 16, 2026
6 checks passed
@patternfly-build

patternfly-build commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Jul 22, 2026
Closed
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@thatblindgeye @dlabaj
fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)
f12c880
@dlabaj dlabaj mentioned this pull request Jul 28, 2026
Merged
dlabaj pushed a commit that referenced this pull request Jul 28, 2026
@thatblindgeye @dlabaj
fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)
15d9e44
dlabaj added a commit that referenced this pull request Jul 28, 2026
@dlabaj @mcoker
@andrew-ronaldson @jcmill @thatblindgeye
fix: cherry-pick main fixes into 6.6.x (#8531)
60468ef 
* fix: address word-break/overflow-wrap bug (#8487)

* chore(input group): add radius modifier (#8483)

* fix(table): nested table sorting (#8491)

* fix(tree-view): revert caret rotations (#8490)

* fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493)

* fix(tree): update tree table and DLS tree toggle icon direction (#8502)

* fix: update disabled description to use text color token (#8497)

* fix(plain actions): update tokens to vertical-plain (#8495)

* fix: address bottom pagination bugs (#8498)

* fix: address bottom pagination bugs

* fix: round border-radius on default bottom in glass

* chore(primary details): fix drawer and toolbar (#8509)

* fix(modal): footer action spacing (#8526)

---------

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
Co-authored-by: Jake Miller <jake83miller@gmail.com>
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Co-authored-by: Jake Miller <jakmille@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes
@nicolethoen nicolethoen nicolethoen approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thatblindgeye @patternfly-build @rebeccaalpert @nicolethoen