fix(plain actions): update tokens to vertical-plain by jcmill · Pull Request #8495 · patternfly/patternfly

jcmill · 2026-07-14T17:32:20Z

Update 12 components to use --pf-t--global--spacer--control--vertical--plain for plain-styled actions. Updates were applied to specific --pf-t--global--spacer--control--vertical--default or the raw --pf-t--global--spacer--sm tokens in block paddings and margin offsets.

Summary by CodeRabbit

Style
- Refined vertical spacing across accordion, alert, breadcrumb, card, data list, hint, modal, navigation, popover, table, and tree view components.
- Standardized control and action spacing for more consistent alignment and interaction areas.
- Adjusted component padding and margins to improve visual consistency across states and layouts.

coderabbitai · 2026-07-14T17:34:38Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 639ab48f-a98c-4ebb-9ae3-9ffdb31ab9bb

📥 Commits

Reviewing files that changed from the base of the PR and between 1fea0c2 and a1b1db3.

📒 Files selected for processing (2)

src/patternfly/components/Table/table.scss
src/patternfly/components/TreeView/tree-view.scss

Walkthrough

Updated spacing custom properties across 11 PatternFly components, replacing default or generic spacer tokens with plain control and action spacing tokens for padding, margins, insets, and offsets.

Changes

Plain control spacing

Layer / File(s)	Summary
Component spacing token updates `src/patternfly/components/{Accordion,Alert,Breadcrumb,Card,DataList,Hint,ModalBox,Nav,Popover,Table,TreeView}/*.scss`	Vertical padding, margins, insets, and offsets now use plain control spacing tokens; TreeView inline-end padding uses the action-horizontal token, and a DataList outline calculation is reordered.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

patternfly/patternfly#8219: Also updates Card spacing and padding theme tokens.

Suggested labels: released on @prerelease``

Suggested reviewers: mcoker, lboehling, srambach, andrew-ronaldson

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows conventional commit format and accurately describes the token update.
Linked Issues check	✅ Passed	The changes align with `#8251` by updating plain-action padding and related offsets to control-vertical-plain across the affected components.
Out of Scope Changes check	✅ Passed	The edits stay within the spacing-token audit scope, with only related CSS variable updates and no unrelated feature changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/patternfly/components/Table/table.scss`:
- Around line 120-121: Update the table button padding variables near the action
padding definitions so --#{$table}__button--PaddingBlockStart and
--#{$table}__button--PaddingBlockEnd use
--pf-t--global--spacer--control--vertical--plain instead of
--pf-t--global--spacer--sm. Leave the existing action padding variables
unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ab957bc4-b530-4c0e-af7b-6b4a5d13d8d2

📥 Commits

Reviewing files that changed from the base of the PR and between 716f0e5 and efad9e0.

📒 Files selected for processing (12)

src/patternfly/components/Accordion/accordion.scss
src/patternfly/components/Alert/alert.scss
src/patternfly/components/Breadcrumb/breadcrumb.scss
src/patternfly/components/Button/button.scss
src/patternfly/components/Card/card.scss
src/patternfly/components/DataList/data-list.scss
src/patternfly/components/Hint/hint.scss
src/patternfly/components/ModalBox/modal-box.scss
src/patternfly/components/Nav/nav.scss
src/patternfly/components/Popover/popover.scss
src/patternfly/components/Table/table.scss
src/patternfly/components/TreeView/tree-view.scss

patternfly-build · 2026-07-14T17:41:02Z

Preview: https://pf-pr-8495.surge.sh

A11y report: https://pf-pr-8495-a11y.surge.sh

mcoker

Some others I found that we should update or ask design about

Accordion toggle - inline padding still uses spacer--md
- If we're updating accordion and nav, should other things like them be updated?
  - Menu items
  - Dual list selector items
  - Tree view items/nodes
  - Wizard nav/step links
Toggle group buttons need semantic spacers (regular and compact)
Random but I think this could use the text-to-element token

patternfly/src/patternfly/components/ToggleGroup/toggle-group.scss

Line 30 in 716f0e5

--#{$toggle-group}__icon--text--MarginInlineStart: var(--pf-t--global--spacer--sm);

mcoker

L🔥TM

patternfly-build · 2026-07-20T16:07:27Z

🎉 This PR is included in version 6.6.0-prerelease.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix: address word-break/overflow-wrap bug (#8487) * chore(input group): add radius modifier (#8483) * fix(table): nested table sorting (#8491) * fix(tree-view): revert caret rotations (#8490) * fix(a11y): ignore target-size rule for WCAG 2.2 bump (#8493) * fix(tree): update tree table and DLS tree toggle icon direction (#8502) * fix: update disabled description to use text color token (#8497) * fix(plain actions): update tokens to vertical-plain (#8495) * fix: address bottom pagination bugs (#8498) * fix: address bottom pagination bugs * fix: round border-radius on default bottom in glass * chore(primary details): fix drawer and toolbar (#8509) * fix(modal): footer action spacing (#8526) --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com> Co-authored-by: Jake Miller <jake83miller@gmail.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Jake Miller <jakmille@redhat.com>

initial pass on token update for --default and --spacer--sm to --plain

efad9e0

jcmill requested a review from mcoker July 14, 2026 17:32

coderabbitai Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread src/patternfly/components/Table/table.scss Outdated

coderabbitai Bot mentioned this pull request Jul 14, 2026

[Bug] - Sibling checkboxes/radios lack size and/or spacing from one another #8494

Open

update table button token

1fea0c2

mcoker requested changes Jul 16, 2026

View reviewed changes

jcmill added 3 commits July 16, 2026 15:22

revert buttons padding to default

1af4228

revert toggle and action tokens

29c0687

update node paddings

a1b1db3

jcmill requested a review from mcoker July 17, 2026 20:06

mcoker approved these changes Jul 20, 2026

View reviewed changes

mcoker merged commit b6dd1c9 into patternfly:main Jul 20, 2026
6 checks passed

patternfly-build added the released on @prerelease label Jul 20, 2026

This was referenced Jul 20, 2026

Tables: updated cell padding to align toggle/action buttons #8510

Open

fix(tabs): update padding and subtab height #8499

Merged

mcoker mentioned this pull request Jul 22, 2026

6.6 patch checklist - core #8518

Closed

dlabaj pushed a commit that referenced this pull request Jul 28, 2026

fix(plain actions): update tokens to vertical-plain (#8495)

b23d0b4

dlabaj mentioned this pull request Jul 28, 2026

fix: cherry-pick main fixes into 6.6.x #8531

Merged

dlabaj pushed a commit that referenced this pull request Jul 28, 2026

fix(plain actions): update tokens to vertical-plain (#8495)

0ae966b

Navigation Menu

Uh oh!

fix(plain actions): update tokens to vertical-plain - #8495

fix(plain actions): update tokens to vertical-plain#8495
mcoker merged 5 commits into
patternfly:mainfrom
jcmill:bug/8251-update-plain-action-tokens

jcmill commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

patternfly-build commented Jul 14, 2026 •

edited

Loading

Uh oh!

mcoker left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcoker left a comment

Uh oh!

Uh oh!

patternfly-build commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jcmill commented Jul 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patternfly-build commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patternfly-build commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jcmill commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

patternfly-build commented Jul 14, 2026 •

edited

Loading