Release v0.37.0-beta.1 - #1490
Conversation
Signed-off-by: cozystack-bot <217169706+cozystack-bot@users.noreply.github.com>
WalkthroughThis PR updates numerous container image references across the repository, pinning tags (e.g., latest → specific versions), updating digests, and bumping components from v0.37.0-alpha.2 to v0.37.0-beta.1. One indentation fix appears under seaweedfs s3.extraArgs. No control-flow or logic changes are introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (26)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (22)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Cozystack Bot (@cozystack-bot), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a standard release preparation, specifically for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the v0.37.0-beta.1 release by updating various version strings and image tags. The changes are mostly consistent with a release process. My main feedback is around the image tagging strategy. Several images are being retagged from latest to 0.0.0. While removing the latest tag is a good practice, using a generic 0.0.0 tag is not ideal for maintainability and traceability. I've left specific suggestions to use more descriptive tags based on the software version being built or the base image version, where this information is readily available in the corresponding Dockerfiles.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/clickhouse-backup:latest@sha256:0f8707d348e03bfa7589159a61d781d4eca238bdfff5dc09f4d3a01b31285a55 | |||
| ghcr.io/cozystack/cozystack/clickhouse-backup:0.0.0@sha256:3faf7a4cebf390b9053763107482de175aa0fdb88c1e77424fd81100b1c3a205 | |||
There was a problem hiding this comment.
To improve clarity, it's better to use a specific version tag instead of 0.0.0. This image is based on clickhouse/clickhouse-server:24.8.4-alpine, so using a tag like 24.8.4 would be more descriptive.
ghcr.io/cozystack/cozystack/clickhouse-backup:24.8.4@sha256:3faf7a4cebf390b9053763107482de175aa0fdb88c1e77424fd81100b1c3a205
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/cluster-autoscaler:latest@sha256:89f822343654ea66efb3ac50bf72b483a52c1a11d33497fdfac5bbd0f3715c2b | |||
| ghcr.io/cozystack/cozystack/cluster-autoscaler:0.0.0@sha256:2d39989846c3579dd020b9f6c77e6e314cc81aa344eaac0f6d633e723c17196d | |||
There was a problem hiding this comment.
While pinning to a digest is a great practice for reproducibility, using a generic tag like 0.0.0 can be confusing. The Dockerfile for this image builds cluster-autoscaler-1.32.0. It would be more descriptive and maintainable to use a tag that reflects the version of the software being packaged, such as 1.32.0.
ghcr.io/cozystack/cozystack/cluster-autoscaler:1.32.0@sha256:2d39989846c3579dd020b9f6c77e6e314cc81aa344eaac0f6d633e723c17196d
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/kubevirt-cloud-provider:latest@sha256:190b7d231da1dfbded3af77777cc99b93a29a36ea69186170460f09d533fe041 | |||
| ghcr.io/cozystack/cozystack/kubevirt-cloud-provider:0.0.0@sha256:5335c044313b69ee13b30ca4941687e509005e55f4ae25723861edbf2fbd6dd2 | |||
There was a problem hiding this comment.
While pinning to a digest is a great practice, using a generic tag like 0.0.0 can be confusing. The latest tag is being correctly removed, but it would be more descriptive to use a tag that reflects the version of the software being packaged. Since this image is built from a specific git commit (a0acf33), consider using the short commit hash as the tag (e.g., a0acf33) for better traceability.
ghcr.io/cozystack/cozystack/kubevirt-cloud-provider:a0acf33@sha256:5335c044313b69ee13b30ca4941687e509005e55f4ae25723861edbf2fbd6dd2
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/kubevirt-csi-driver:latest@sha256:7312623d19d9a7dc80da73f53a1aabb769796674e5899aad5c0d6100f351d0e8 | |||
| ghcr.io/cozystack/cozystack/kubevirt-csi-driver:0.0.0@sha256:6d3fc4246928f65e784cd8822457c505a8a3742b51a072ebdb43d9570ec10b39 | |||
There was a problem hiding this comment.
While pinning to a digest is a great practice, using a generic tag like 0.0.0 can be confusing. The latest tag is being correctly removed, but it would be more descriptive to use a tag that reflects the version of the software being packaged. Since this image is built from a specific git commit (a8d6605b...), consider using the short commit hash as the tag (e.g., a8d6605b) for better traceability.
ghcr.io/cozystack/cozystack/kubevirt-csi-driver:a8d6605b@sha256:6d3fc4246928f65e784cd8822457c505a8a3742b51a072ebdb43d9570ec10b39
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/grafana:latest@sha256:dc27b9d7ef42e3d59667a203cb94d410c60afc119102ff1b9a081af4ea72f52c | |||
| ghcr.io/cozystack/cozystack/grafana:0.0.0@sha256:c63978e1ed0304e8518b31ddee56c4e8115541b997d8efbe1c0a74da57140399 | |||
There was a problem hiding this comment.
| storageClass: replicated | ||
| csiDriver: | ||
| image: ghcr.io/cozystack/cozystack/kubevirt-csi-driver:latest@sha256:7312623d19d9a7dc80da73f53a1aabb769796674e5899aad5c0d6100f351d0e8 | ||
| image: ghcr.io/cozystack/cozystack/kubevirt-csi-driver:0.0.0@sha256:6d3fc4246928f65e784cd8822457c505a8a3742b51a072ebdb43d9570ec10b39 |
There was a problem hiding this comment.
Using the latest tag is a bad practice, and it's good that it's being replaced. However, 0.0.0 is not a descriptive tag. Consider using a tag that reflects the source, for example, by using a short git SHA from the build (a8d6605b), to improve traceability and maintainability.
image: ghcr.io/cozystack/cozystack/kubevirt-csi-driver:a8d6605b@sha256:6d3fc4246928f65e784cd8822457c505a8a3742b51a072ebdb43d9570ec10b39
This PR prepares the release
v0.37.0-beta.1.Summary by CodeRabbit