Release v1.0.0-beta.3 - #2030
Conversation
Signed-off-by: cozystack-bot <217169706+cozystack-bot@users.noreply.github.com>
📝 WalkthroughWalkthroughThis PR updates container image tags and SHA256 digests across 25+ configuration files in the repository. Most changes involve version bumps from v1.0.0-beta.2 to v1.0.0-beta.3, with corresponding digest updates. Additional image versions for matchbox, s3manager, and linstor components are also updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Cozystack Bot (@cozystack-bot), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates all component image references and configuration values to align with the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates various components to version v1.0.0-beta.3. The changes mostly involve updating container image tags and digests. However, I've noticed several inconsistencies in the image references:
- In some cases, the version tag was updated, but the image digest remained the same as the previous version.
- In other cases, the image digest was updated, but the version tag was not incremented.
These inconsistencies can lead to confusion and unpredictable deployments. It's crucial to follow a strict image tagging policy where each new image build gets a unique tag and digest, and tags are treated as immutable. Please see the detailed comments for specific instances.
| @@ -1,2 +1,2 @@ | |||
| e2e: | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.0.0-beta.2@sha256:eac71ef0de3450fce96255629e77903630c63ade62b81e7055f1a689f92ee153 | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.0.0-beta.3@sha256:eac71ef0de3450fce96255629e77903630c63ade62b81e7055f1a689f92ee153 | |||
There was a problem hiding this comment.
The image tag has been updated to v1.0.0-beta.3, but the SHA256 digest is identical to the one for the previous version (v1.0.0-beta.2). This suggests an issue in the release process. If the image content has not changed, the tag should not be updated. If it has, the digest should be different, indicating a new build.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/s3manager:v0.5.0@sha256:3013e13ba967070948653cc5b913a920dea93a24370b10731fafcfd8fb6a21b0 | |||
| ghcr.io/cozystack/cozystack/s3manager:v0.5.0@sha256:291427de7db54a1d19dc9c2c807bdcc664a14caa9538786f31317e8c01a4a008 | |||
There was a problem hiding this comment.
The image digest has been updated, but the tag v0.5.0 remains unchanged. This indicates that the image content has changed, but the version tag was not incremented. To ensure predictability and avoid confusion, container image tags should be treated as immutable. A new image build should receive a new, unique tag (e.g., by incrementing the patch version).
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.0.0-beta.2@sha256:e866b5b3874b9d390b341183d2ee070e1387440c14cfe51af831695def6dc2ec | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.0.0-beta.3@sha256:e866b5b3874b9d390b341183d2ee070e1387440c14cfe51af831695def6dc2ec | |||
There was a problem hiding this comment.
The image tag has been updated to v1.0.0-beta.3, but the SHA256 digest is identical to the one for the previous version (v1.0.0-beta.2). This suggests an issue in the release process. If the image content has not changed, the tag should not be updated. If it has, the digest should be different, indicating a new build.
| portSecurity: true | ||
| routes: "" | ||
| image: ghcr.io/cozystack/cozystack/kubeovn-webhook:v1.0.0-beta.2@sha256:e18f9fd679e38f65362a8d0042f25468272f6d081136ad47027168d8e7e07a4a | ||
| image: ghcr.io/cozystack/cozystack/kubeovn-webhook:v1.0.0-beta.3@sha256:e18f9fd679e38f65362a8d0042f25468272f6d081136ad47027168d8e7e07a4a |
There was a problem hiding this comment.
The image tag has been updated to v1.0.0-beta.3, but the SHA256 digest is identical to the one for the previous version (v1.0.0-beta.2). This suggests an issue in the release process. If the image content has not changed, the tag should not be updated. If it has, the digest should be different, indicating a new build.
| image: | ||
| repository: ghcr.io/cozystack/cozystack/piraeus-server | ||
| tag: 1.32.3@sha256:0e78fa31a3fe4ec2af43d1e59a9fc0f6d765780e32d473e18e1c495714051802 | ||
| tag: 1.32.3@sha256:66eadfc98cd809d2b3c4e6fd631bcd0c4b4cd72a7fb819ac4a0cab7904280546 |
There was a problem hiding this comment.
The image digest for piraeus-server has been updated, but the tag 1.32.3 remains unchanged. This indicates that the image content has changed, but the version tag was not incremented. To ensure predictability and avoid confusion, container image tags should be treated as immutable. A new image build should receive a new, unique tag.
| image: | ||
| repository: ghcr.io/cozystack/cozystack/linstor-csi | ||
| tag: v1.10.5@sha256:68465f120cfeec3d7ccbb389dd9bdbf7df1675da3ab9ba91c3feff21a799bc36 | ||
| tag: v1.10.5@sha256:6e6cf48cb994f3918df946e02ec454ac64916678b3e60d78c136b431f1a26155 |
There was a problem hiding this comment.
The image digest for linstor-csi has been updated, but the tag v1.10.5 remains unchanged. This indicates that the image content has changed, but the version tag was not incremented. To ensure predictability and avoid confusion, container image tags should be treated as immutable. A new image build should receive a new, unique tag.
| image: | ||
| pullPolicy: IfNotPresent | ||
| tag: v1.0.0-beta.2@sha256:d5f2fa2972ba33cd2ccb855256e4bda4734d7e250638811b77f2e0dc72ad6b19 | ||
| tag: v1.0.0-beta.3@sha256:fe9b6bb548edfc26be8aaac65801d598a4e2f9884ddf748083b9e509fa00259e |
There was a problem hiding this comment.
The image digest for kamaji has been updated, but the tag v1.0.0-beta.3 is also used for the --migrate-image argument on line 16. While this is consistent within this file, it's worth noting that using the same image for both the controller and migration can be risky if migrations are not idempotent or if a rollback is needed. A dedicated, versioned migration image could provide more safety.
This PR prepares the release
v1.0.0-beta.3.Summary by CodeRabbit
Release Notes