Release v0.37.0-beta.2 - #1496
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR updates multiple container image references: most bump from v0.37.0-beta.1 to v0.37.0-beta.2 with new sha256 digests; several files update only image digests while retaining the same tag. No structural, behavioral, or control-flow modifications. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewersPoem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (14)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Cozystack Bot (@cozystack-bot), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is dedicated to preparing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the v0.37.0-beta.2 release by updating various image tags and version strings across the repository. The changes are mostly consistent with the new version. However, I've identified a few areas for improvement regarding maintainability and a potential issue with an image digest. My review includes suggestions to reduce redundancy in configuration files by using single sources of truth for version strings and image URLs. I also flagged an image that has been retagged with a new version but retains the old digest, which could indicate a problem in the release pipeline.
| image: ghcr.io/cozystack/cozystack/openapi-ui-k8s-bff:v0.37.0-beta.2@sha256:ff741c909f481c611708eaa71790b0e76cc2597e3ac0fc0c74a590be1a74fc95 | ||
| tokenProxy: | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v0.37.0-beta.1@sha256:fad27112617bb17816702571e1f39d0ac3fe5283468d25eb12f79906cdab566b | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v0.37.0-beta.2@sha256:fad27112617bb17816702571e1f39d0ac3fe5283468d25eb12f79906cdab566b |
There was a problem hiding this comment.
The image tag for token-proxy has been updated to v0.37.0-beta.2, but the SHA256 digest is identical to the one for v0.37.0-beta.1. This suggests that either the image was not rebuilt with new changes, or it was retagged without any modifications. If changes were intended for this release, they might be missing from this image.
| image: ghcr.io/cozystack/cozystack/cozystack-controller:v0.37.0-beta.2@sha256:8d5ddd0fb7f71808f4e29d3b24a65f6f135ca9ecc96591a69ff61f63c286fd8a | ||
| debug: false | ||
| disableTelemetry: false | ||
| cozystackVersion: "v0.37.0-beta.1" | ||
| cozystackVersion: "v0.37.0-beta.2" |
There was a problem hiding this comment.
The version v0.37.0-beta.2 is specified in both the image tag and the cozystackVersion field. This redundancy can lead to inconsistencies during updates. To improve maintainability, the image tag should be constructed dynamically in the templates using the cozystackVersion value, making it the single source of truth for the version.1
Rules References
Footnotes
-
Avoid redundant configuration. Values that can be derived from others should be constructed in templates to maintain a single source of truth and reduce the chance of errors during updates. ↩
| {{- $brandingConfig:= lookup "v1" "ConfigMap" "cozy-system" "cozystack-branding" }} | ||
|
|
||
| {{- $tenantText := "v0.37.0-beta.1" }} | ||
| {{- $tenantText := "v0.37.0-beta.2" }} |
There was a problem hiding this comment.
Hardcoding the version string here makes it difficult to maintain and easy to forget to update for new releases. It's better to use a single source of truth for the version. Consider using the chart's application version from Chart.yaml.1
{{- $tenantText := .Chart.AppVersion }}Rules References
Footnotes
-
For better maintainability, avoid hardcoding version strings in templates. Use a value from
Chart.yaml(like.Chart.AppVersion) orvalues.yamlas the single source of truth. ↩
| memory: 100Mi | ||
| extraArgs: | ||
| - --migrate-image=ghcr.io/cozystack/cozystack/kamaji:v0.37.0-beta.1@sha256:7b88e2534912ac4b32b6fd9b51eb4571193d95ee696fa35a8dcd1ae2913e970b | ||
| - --migrate-image=ghcr.io/cozystack/cozystack/kamaji:v0.37.0-beta.2@sha256:9f4fd5045ede2909fbaf2572e4138fcbd8921071ecf8f08446257fddd0e6f655 |
There was a problem hiding this comment.
The full image URL for --migrate-image is hardcoded here, while the components of the URL (repository and tag) are already defined under the image key. This duplication is error-prone. The --migrate-image argument should be constructed in the template using the values from kamaji.image to ensure consistency and simplify future updates.1
Rules References
Footnotes
-
Avoid redundant configuration. Values that can be derived from others should be constructed in templates to maintain a single source of truth and reduce the chance of errors during updates. ↩
0e21b25 to
557bed9
Compare
Signed-off-by: cozystack-bot <217169706+cozystack-bot@users.noreply.github.com>
557bed9 to
a50f53d
Compare
This PR prepares the release
v0.37.0-beta.2.Summary by CodeRabbit