Release v0.37.0-alpha.1 - #1467
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR updates numerous container image references across apps, core, extra, and system packages—replacing floating tags (e.g., latest) with explicit versioned tags/digests (e.g., v0.37.0-alpha.1, v1.32, 1.17.5, v1.14.5, 0.0.0) and adjusts a few branding/version fields. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (26)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (13)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Cozystack Bot (@cozystack-bot), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is dedicated to preparing for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the v0.37.0-alpha.1 release by updating various image tags and version numbers. The changes are mostly correct, but there are several critical issues with image tagging and digests that need to be addressed. Specifically, some images are tagged with 0.0.0, some have mismatched tags and digests, and some use mutable tags. These issues could lead to incorrect image deployments and should be fixed before merging.
| tag: 1.17.5 | ||
| digest: "sha256:2def2dccfc17870be6e1d63584c25b32e812f21c9cdcfa06deadd2787606654d" |
There was a problem hiding this comment.
The image tag has been updated to 1.17.5, but the digest has not been updated. The current digest sha256:2def2dccfc17870be6e1d63584c25b32e812f21c9cdcfa06deadd2787606654d likely corresponds to the old latest tag. When both tag and digest are specified, Kubernetes uses the digest to pull the image, effectively ignoring the tag. This will result in deploying an old version of the image. Please update the digest to match the 1.17.5 tag, or remove the digest field to pull by tag.
| image: ghcr.io/cozystack/cozystack/openapi-ui-k8s-bff:v0.37.0-alpha.1@sha256:d9873f3557380250d98dc884cb269c1534bd23b11d7096b2aa17e6e4bc34cc0d | ||
| tokenProxy: | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:latest@sha256:fad27112617bb17816702571e1f39d0ac3fe5283468d25eb12f79906cdab566b | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v0.37.0-alpha.1@sha256:fad27112617bb17816702571e1f39d0ac3fe5283468d25eb12f79906cdab566b |
There was a problem hiding this comment.
The token-proxy image tag has been updated to v0.37.0-alpha.1, but the digest sha256:fad27112617bb17816702571e1f39d0ac3fe5283468d25eb12f79906cdab566b is the same as for the previous latest tag. It is highly unlikely that the new version has the exact same digest as the old one, especially for a release. This suggests that either the image was not rebuilt, or the digest was not updated. Please verify and provide the correct digest for the v0.37.0-alpha.1 image.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/clickhouse-backup:latest@sha256:0f8707d348e03bfa7589159a61d781d4eca238bdfff5dc09f4d3a01b31285a55 | |||
| ghcr.io/cozystack/cozystack/clickhouse-backup:0.0.0@sha256:3faf7a4cebf390b9053763107482de175aa0fdb88c1e77424fd81100b1c3a205 | |||
There was a problem hiding this comment.
The image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1 used in other parts of this pull request. Using a 0.0.0 tag can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image, ideally aligned with the release version if it's a component of this project.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/nginx-cache:latest@sha256:a4ab68c6930263b80f7d0c75f9c87ff9725a835db3f23c6a655993ec4feed49c | |||
| ghcr.io/cozystack/cozystack/nginx-cache:0.0.0@sha256:b7633717cd7449c0042ae92d8ca9b36e4d69566561f5c7d44e21058e7d05c6d5 | |||
There was a problem hiding this comment.
The image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1 used in other parts of this pull request. Using a 0.0.0 tag can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image, ideally aligned with the release version if it's a component of this project.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/cluster-autoscaler:latest@sha256:89f822343654ea66efb3ac50bf72b483a52c1a11d33497fdfac5bbd0f3715c2b | |||
| ghcr.io/cozystack/cozystack/cluster-autoscaler:0.0.0@sha256:2d39989846c3579dd020b9f6c77e6e314cc81aa344eaac0f6d633e723c17196d | |||
There was a problem hiding this comment.
The image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1 used in other parts of this pull request. Using a 0.0.0 tag can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image, ideally aligned with the release version if it's a component of this project.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/mariadb-backup:latest@sha256:abfc43aed08fbbeed8f090e90158108fe59ed6279db93d169c3b1b1656af0064 | |||
| ghcr.io/cozystack/cozystack/mariadb-backup:0.0.0@sha256:a3789db9e9e065ff60cbac70771b4a8aa1460db3194307cf5ca5d4fe1b412b6b | |||
There was a problem hiding this comment.
The image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1 used in other parts of this pull request. Using a 0.0.0 tag can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image, ideally aligned with the release version if it's a component of this project.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/grafana:latest@sha256:cc1843297f2dadb1740ebc4dfdc3dbe5b4ac840d1da37ed6fe93549d3000196c | |||
| ghcr.io/cozystack/cozystack/grafana:0.0.0@sha256:c63978e1ed0304e8518b31ddee56c4e8115541b997d8efbe1c0a74da57140399 | |||
There was a problem hiding this comment.
The image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1 used in other parts of this pull request. Using a 0.0.0 tag can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image, ideally aligned with the release version if it's a component of this project.
| storageClass: replicated | ||
| csiDriver: | ||
| image: ghcr.io/cozystack/cozystack/kubevirt-csi-driver:latest@sha256:35684db82ef7d5ad0cb39fa2568aa09cf60c50f3307099dbb89521aefad5baf6 | ||
| image: ghcr.io/cozystack/cozystack/kubevirt-csi-driver:0.0.0@sha256:f0e1d9f9e91be8e4a22be9fbe01a8b0e81aba4230b865fba9608ef7f9fb5745f |
There was a problem hiding this comment.
The kubevirt-csi-driver image tag has been updated to 0.0.0. This is not a valid semantic version and is inconsistent with the release version v0.37.0-alpha.1. Using 0.0.0 can lead to confusion and potential issues with image pulling policies. Please use a specific, meaningful version for this image. Note that the source for this image tag, packages/apps/kubernetes/images/kubevirt-csi-driver.tag, is also updated to 0.0.0 in this PR.
| image: | ||
| repository: ghcr.io/cozystack/cozystack/metallb-controller | ||
| tag: v0.15.2@sha256:5106869c470fcce9e1ef1e07efe5224190ad19e8006d5889230a75df4988b68d | ||
| tag: v0.15.2@sha256:0e9080234fc8eedab78ad2831fb38df375c383e901a752d72b353c8d13b9605f |
There was a problem hiding this comment.
The digest for the metallb-controller image has been updated, but the tag v0.15.2 remains the same. This indicates that the image content has changed, but it's being published under a pre-existing tag. This is a bad practice known as using mutable tags. It can lead to inconsistencies and issues with deployments, especially in environments with image pull policies like IfNotPresent. It is strongly recommended to use unique, immutable tags for each new image build, for example by bumping a patch or build version (e.g., v0.15.2-cozystack.1).
| image: | ||
| repository: ghcr.io/cozystack/cozystack/metallb-speaker | ||
| tag: v0.15.2@sha256:2b837031e3c693c0fa0de0ad5a9036e2aabb5e90a7a235e19b089be73af11160 | ||
| tag: v0.15.2@sha256:e14d4c328c3ab91a6eadfeea90da96388503492d165e7e8582f291b1872e53b2 |
There was a problem hiding this comment.
The digest for the metallb-speaker image has been updated, but the tag v0.15.2 remains the same. This indicates that the image content has changed, but it's being published under a pre-existing tag. This is a bad practice known as using mutable tags. It can lead to inconsistencies and issues with deployments, especially in environments with image pull policies like IfNotPresent. It is strongly recommended to use unique, immutable tags for each new image build, for example by bumping a patch or build version (e.g., v0.15.2-cozystack.1).
Signed-off-by: cozystack-bot <217169706+cozystack-bot@users.noreply.github.com>
3242e02 to
93ddc4e
Compare
This PR prepares the release
v0.37.0-alpha.1.Summary by CodeRabbit