More Blues + Less Classical - #4952
Closed
OregSamSas wants to merge 3 commits into
Closed
Conversation
cobaltt7
suggested changes
Aug 5, 2022
Contributor
Author
I think it's ugly when there's still orange elements. But perhaps really I'm the only one who thinks like this.
Thanks, maybe I shall remove other commits and keep only this one of people support just that thing. (But it's possible to merge just a few of a PR's commits isn't it? So maybe I don't have to do more yet) |
Closed
WorldLanguages
removed their request for review
October 19, 2022 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4935
Changes
No. 1: Complete Blues on Beta (aka. Full De Daba Dei)
No. 2: Remove blue toggles from stable (aka. what the title of the linked issue sez)
I've replaced most of the orange colours when it's a prerelease version (No. 1), and also removed the blue colour of the setting options' toggles(No. 2). Now it's a less saturated type of that colour which is set to the main. (i. e. the "--brand-orange" variable)
Screenshot1
Screenshot2
Screenshot3
Screenshot4
Screenshots 5, 6
Screenshots 7, 8
Reason for changes
Changing helps distinguish whether the enabled addon is a beta version or not, and also looks better.
Tests
I've tested all of the changes on all platforms (Chrome 103.0, Waterfox G4.1.3.2, Edge 103.0), and sadly it didn't work somehow on Microsoft Edge with prerelease versions, but I open the pull request anyway (considering that not many people will probably use Edge for beta-testing)
Related PR
#4934 But in my version, the colour of input borders on focusing are altering on the type of the SA version (beta=>blue/stable=>orange)
See image...
For the reason I prefer this way, but I can change it to Samq64's ideas if that will have been merged, and not this.
My previous proposal can be found here: #4936