Skip to content

Fix a couple bugs from #4810 - #4934

Merged
apple502j merged 5 commits into
ScratchAddons:masterfrom
Samq64:fix-orange-border
Aug 6, 2022
Merged

Fix a couple bugs from #4810#4934
apple502j merged 5 commits into
ScratchAddons:masterfrom
Samq64:fix-orange-border

Conversation

@Samq64

@Samq64 Samq64 commented Aug 1, 2022

Copy link
Copy Markdown
Member

Fixes #4930 (comment) and incorrect icon preload path. Tested on Chromium 103.

@Samq64
Samq64 requested a review from WorldLanguages as a code owner August 1, 2022 16:38
@Samq64 Samq64 changed the title Update global-theme.js Fix focused input border Aug 1, 2022
@mxmou

mxmou commented Aug 1, 2022

Copy link
Copy Markdown
Member

Ideally the solution would be consistent with buttons, which #4930 changed back to orange.

@Samq64

Samq64 commented Aug 1, 2022

Copy link
Copy Markdown
Member Author

Ideally the solution would be consistent with buttons, which #4930 changed back to orange.

They're now always orange and I renamed brand-orange-opacity35 to orange-opacity35.

@OregSamSas OregSamSas mentioned this pull request Aug 2, 2022
@OregSamSas

Copy link
Copy Markdown
Contributor

I think it's better to have it as blue in beta versions, but then it seems I'm the only one who's thinking like this.

@mxmou

mxmou commented Aug 2, 2022

Copy link
Copy Markdown
Member

I think it's better to have it as blue in beta versions, but then it seems I'm the only one who's thinking like this.

I don't think the exact color is very important, it just has to be the same for inputs and buttons.

@WorldLanguages
WorldLanguages requested a review from mxmou August 4, 2022 22:54
@Samq64 Samq64 changed the title Fix focused input border Fix a couple bugs from 4810 Aug 5, 2022
@Samq64 Samq64 changed the title Fix a couple bugs from 4810 Fix a couple bugs from #4810 Aug 5, 2022
@apple502j
apple502j merged commit 1411f6c into ScratchAddons:master Aug 6, 2022
@Samq64
Samq64 deleted the fix-orange-border branch August 6, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants