Update styles - #4936
Closed
OregSamSas wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Wait there's #4934 |
Contributor
Author
|
Borders on focusing in this PR changes as well like this: |
Contributor
Author
|
But why did this get closed? I don't get it. (My guesses would be because it has conflicts with that PR, or it's already implemented with another PR, or the changes wasn't necessary, but I haven't got any exact idea.) |
Contributor
Author
|
I can change the colour of focused input borders, if it's the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4935
Changes
I've replaced most of the orange colours when it's a prerelease version, and also removed the blue colour of the setting options' toggles. Now it's a less saturated type of that colour which is set to the main. (i. e. the "--brand-orange" variable)
Screenshot1
Screenshot2
Screenshot3
Screenshot4
Screenshots 5, 6
Screenshots 7, 8
Reason for changes
Changing helps distinguish whether the enabled addon is a beta version or not, and also looks better.
Tests
I've tested all of the changes on all platforms (Chrome 103.0, Waterfox G4.1.3.2, Edge 103.0), and sadly it didn't work somehow on Microsoft Edge with prerelease versions, but I open the pull request anyway (considering that not many people will probably use Edge for beta-testing)