Skip to content

Color changes - #4989

Closed
mxmou wants to merge 3 commits into
ScratchAddons:masterfrom
mxmou:use-colors
Closed

Color changes#4989
mxmou wants to merge 3 commits into
ScratchAddons:masterfrom
mxmou:use-colors

Conversation

@mxmou

@mxmou mxmou commented Aug 16, 2022

Copy link
Copy Markdown
Member

Resolves #4983
Closes #4952

Also replaces some icons with inline SVGs for easier styling. Marking as draft for discussion.

Comment thread webpages/common/components/inline-icon.html Outdated
@WorldLanguages

Copy link
Copy Markdown
Member

Can you send screenshots of the visual changes?

Or is the discussion about the creation of an <inline-icon> component? We should be careful and check if settings page performance is affected by that. Vue will probably need to handle many more JS objects in memory and there may be more DOM nodes.

@mxmou

mxmou commented Aug 29, 2022

Copy link
Copy Markdown
Member Author

Can you send screenshots of the visual changes?

image
image
image
image
image
image

@Hans5958

Hans5958 commented Oct 8, 2022

Copy link
Copy Markdown
Member

This will require changes on the docs, specifically on the Design page.

@Samq64 Samq64 added scope: design Related to design of the extension scope: webpages Related to the web pages (settings page, pop-up, etc) labels Dec 18, 2022
@mxmou mxmou closed this Jul 6, 2023
@mxmou

mxmou commented Jul 6, 2023

Copy link
Copy Markdown
Member Author

This has been open for almost a year and no progress has been made. I'll probably split it into smaller PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: design Related to design of the extension scope: webpages Related to the web pages (settings page, pop-up, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use colors in our UIs in a more meaningful way

5 participants