Skip to content

Merge master into next. - #262

Merged
jbj merged 46 commits into
github:nextfrom
adityasharad:merge/master-next-011018
Oct 2, 2018
Merged

jbj merged 46 commits into
github:nextfrom
adityasharad:merge/master-next-011018

Conversation

@adityasharad

@adityasharad adityasharad commented Oct 1, 2018

Copy link
Copy Markdown
Collaborator

Should be merged after the corresponding internal PR. Test results should be checked on the internal PR instead of this one.

Robert Marsh and others added 30 commits September 20, 2018 10:06
For ease of reviewing, I've checked in the .expected files from the
AST-based guards library. The next commit accepts output for these tests
and adds tests that use getAST rather than the translation layer.
We have external users editing queries with Visual Studio, and it seems
to automatically add very specific files to `.gitignore`. These changes
cause conflicts between unrelated PRs.

This commit adds all of `/.vs` to `.gitignore`, which should hopfully
make Visual Studio stop adding more entries.
Approved by hvitved, xiemaisi, yh-semmle
.gitignore everything under .vs in repo root dir
The IR for the conversion to bool results in a comparison where the left
hand side is not the result of any expression in the AST, so they can't
be usefully converted back to the AST
Robert Marsh and others added 16 commits September 27, 2018 13:09
This is motivated by test performance; IR compilation happens separately
for each test and takes a bit over a minute, so combining these 8 tests
saves about 10 minutes of test running.
…1.18

Version: Fix C# and JavaScript Eclipse plugins for 1.18.
Previously, `Instruction.toString()` returned the same string that is used in IR dumps, which requires numbering all instructions and generating a unique string for each instruction. This is too expensive on large snapshots. I've moved the original code into the new `Instruction.getDumpString()`, and made `Instruction.toString()` just return the opcode plus `getAST().toString()`.
…String

C++: Make `Instruction.toString()` less expensive
JavaScript: Update model of `DOMException`.
@adityasharad adityasharad added depends on internal PR This PR should only be merged in sync with an internal Semmle PR Mergeback labels Oct 1, 2018
@adityasharad
adityasharad requested a review from aibaars October 1, 2018 16:49
@adityasharad
adityasharad requested review from a team as code owners October 1, 2018 16:49
@adityasharad adityasharad mentioned this pull request Oct 1, 2018
@adityasharad
adityasharad removed request for a team October 1, 2018 17:24
@jbj
jbj merged commit 6bfa59a into github:next Oct 2, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on internal PR This PR should only be merged in sync with an internal Semmle PR Mergeback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants