Skip to content

Java: Improve performance of TypeFlow. - #244

Merged
semmle-qlci merged 1 commit into
github:masterfrom
aschackmull:java/typeflow-perf
Sep 29, 2018
Merged

Java: Improve performance of TypeFlow.#244
semmle-qlci merged 1 commit into
github:masterfrom
aschackmull:java/typeflow-perf

Conversation

@aschackmull

@aschackmull aschackmull commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

This improves performance of two predicates in TypeFlow.

Observed timings on a large snapshot (9 MLoc):
Before:

TypeFlow::downcastSuccessor#ff ............. 2m21s
TypeFlow::upcastEnhancedForStmt#ff ......... 1m52s

After:

TypeFlow::downcastSuccessor#ff ............. 2.9s
TypeFlow::downcastSuccessorAux#fffff ....... 147ms
TypeFlow::upcastEnhancedForStmtAux#ffff .... 83ms
TypeFlow::upcastEnhancedForStmt#ff ......... 35ms

@aschackmull
aschackmull requested a review from a team as a code owner September 27, 2018 13:44
@semmle-qlci
semmle-qlci merged commit 89183bd into github:master Sep 29, 2018
@aschackmull
aschackmull deleted the java/typeflow-perf branch October 1, 2018 08:30
aibaars pushed a commit that referenced this pull request Oct 14, 2021
@nickrolfe
Merge pull request #244 from github/script_cleanup
78b64da 
Tidy up shell scripts
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
@dilanbhalla
Merge pull request github#244 from microsoft/lwsimpkins/fix-qhelp
64bc3ed 
fix failing qhelp files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@yh-semmle yh-semmle yh-semmle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aschackmull @yh-semmle @semmle-qlci