Skip to content

Master-to-next merge - #261

Closed
semmle-qlci wants to merge 45 commits into
nextfrom
qlucie/master
Closed

semmle-qlci wants to merge 45 commits into
nextfrom
qlucie/master

Conversation

@semmle-qlci

Copy link
Copy Markdown
Contributor

Automatically created merge PR, pulling recent master changes into next.

Robert Marsh and others added 30 commits September 20, 2018 10:06
For ease of reviewing, I've checked in the .expected files from the
AST-based guards library. The next commit accepts output for these tests
and adds tests that use getAST rather than the translation layer.
We have external users editing queries with Visual Studio, and it seems
to automatically add very specific files to `.gitignore`. These changes
cause conflicts between unrelated PRs.

This commit adds all of `/.vs` to `.gitignore`, which should hopfully
make Visual Studio stop adding more entries.
Approved by hvitved, xiemaisi, yh-semmle
.gitignore everything under .vs in repo root dir
The IR for the conversion to bool results in a comparison where the left
hand side is not the result of any expression in the AST, so they can't
be usefully converted back to the AST
Robert Marsh and others added 15 commits September 27, 2018 13:09
This is motivated by test performance; IR compilation happens separately
for each test and takes a bit over a minute, so combining these 8 tests
saves about 10 minutes of test running.
Version: Fix C# and JavaScript Eclipse plugins for 1.18.
Previously, `Instruction.toString()` returned the same string that is used in IR dumps, which requires numbering all instructions and generating a unique string for each instruction. This is too expensive on large snapshots. I've moved the original code into the new `Instruction.getDumpString()`, and made `Instruction.toString()` just return the opcode plus `getAST().toString()`.
C++: Make `Instruction.toString()` less expensive
JavaScript: Update model of `DOMException`.
@semmle-qlci
semmle-qlci requested review from a team as code owners October 1, 2018 16:42
@ghost

ghost commented Oct 1, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@adityasharad

Copy link
Copy Markdown
Collaborator

Closing in favour of #262.

aibaars pushed a commit that referenced this pull request Oct 14, 2021
smowton added a commit to smowton/codeql that referenced this pull request Apr 16, 2022
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
…variables-2

PS: Global flow through environment variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants