JS: Recognize Express headers as RequestInputAccess - #231
Merged
Merged
Conversation
xiemaisi
suggested changes
Sep 26, 2018
xiemaisi
left a comment
There was a problem hiding this comment.
LGTM, modulo one minor suggestion. Is this covered by an existing change note?
| // `req.headers.name` | ||
| kind = "header" and | ||
| headers.accesses(request, "headers") and | ||
| this = headers.getAPropertyRead(_)) |
There was a problem hiding this comment.
Perhaps use getAPropertyRead() instead (without the don't-care argument) so it also considers dynamic property reads?
Contributor
Author
There was a problem hiding this comment.
👍 Thanks for spotting that.
xiemaisi
approved these changes
Sep 26, 2018
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
Introduce cast for `<unsafe-coerce>` calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
req.headers.xwas missing from the Express model. I've also thrown inreq.hostandreq.hostnameas they are derived from headers.Evaluation looks good. It gives rise to a false positive due to the Reflected XSS query treating headers as sources, which it really shouldn't. I'll put up a separate PR for that separately.