Skip to content

Updating submodules#929

Closed
diraol wants to merge 102 commits intomasterfrom
update_submodules
Closed

Updating submodules#929
diraol wants to merge 102 commits intomasterfrom
update_submodules

Conversation

@diraol
Copy link
Copy Markdown
Contributor

@diraol diraol commented Aug 5, 2018

No description provided.

klen and others added 30 commits June 29, 2017 16:45
Better to redirect to Stackoverflow as very few people log into the slack channel to reply.
Slack now has tonnes of unanswered question
diraol and others added 28 commits March 27, 2018 12:06
…ions

Add proper vim-plug installation instructions
Add submodules's path to sys.path for msys2 platform #852 with correc…
If there is a python3 installed on the system, then it is going to be
the default to be used. Otherwise, we use just the python command. It
can even be a python3 version, in systems that only have python3 or the
python command is linked to the python3 version.

This commit fixes #896.
Move astroid from pymode/libs to submodules and update
Move pylint from pymode/libs to submodules and update
Move rope from pymode/libs to submodules and update
Update logilab to 1.4.1 from PyPI
Update submodules recursively
Move astroid from pymode/libs to submodules and update
Move pylint from pymode/libs to submodules and update
Move rope from pymode/libs to submodules and update
Update logilab to 1.4.1 from PyPI
Update submodules recursively

Also move astroid submodule to the right path.
And update snowball_py submodule.

Resolve #904
Add type key to found occurence.

Pressing `C-c f` results in IndexError because found occurrence dictionary don't have key 'type' (required by `g:PymodeLocList.extend`).

Related issue #921 

Explanation related to the fix retrieved from the related issue:

This error is related to ``PymodeLocList``. It is used to display places in code where rope has found occurences.

https://github.com/python-mode/python-mode/blob/bb746d0d0cba9adedbac856429e37a0dbfc599c6/autoload/pymode/rope.vim#L60

But it is also (or mostly used) by linters to display line of code with error of warnings (type 'E' or 'W'), when list of locations is extended new entries are filtered over type.

https://github.com/python-mode/python-mode/blob/bb746d0d0cba9adedbac856429e37a0dbfc599c6/autoload/pymode/tools/loclist.vim#L54

This type is later displayed next to line number. I wasn't sure what to put for rope so I've added empty string.
Update astroid and pylint submodules
@diraol diraol closed this Aug 5, 2018
@diraol diraol deleted the update_submodules branch August 5, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.