Add type key to found occurence.#914
Merged
diraol merged 1 commit intopython-mode:developfrom Jul 23, 2018
Merged
Conversation
|
It |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing
C-c fresults in IndexError because found occurrence dictionary don't have key 'type' (required byg:PymodeLocList.extend).Related issue #921
Explanation related to the fix retrieved from the related issue:
This error is related to
PymodeLocList. It is used to display places in code where rope has found occurences.python-mode/autoload/pymode/rope.vim
Line 60 in bb746d0
But it is also (or mostly used) by linters to display line of code with error of warnings (type 'E' or 'W'), when list of locations is extended new entries are filtered over type.
python-mode/autoload/pymode/tools/loclist.vim
Line 54 in bb746d0
This type is later displayed next to line number. I wasn't sure what to put for rope so I've added empty string.