This repository was archived by the owner on Apr 23, 2026. It is now read-only.
feat: friendlier 'make' - #1156
Merged
Merged
Conversation
tiran
reviewed
May 14, 2024
tiran
reviewed
May 14, 2024
leseb
force-pushed
the
make-safeguard
branch
3 times, most recently
from
May 14, 2024 13:52
df38d23 to
6677b7a
Compare
Contributor
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
nathan-weinberg
force-pushed
the
make-safeguard
branch
from
May 15, 2024 12:25
8ddb11e to
dca8680
Compare
Now 'make' checks for commands being present or not before running targets. It handles missing commands nicely. Signed-off-by: Sébastien Han <seb@redhat.com>
Instead of calling tox we use make, which helps us validate the make file. Signed-off-by: Sébastien Han <seb@redhat.com>
'podman' was enforced, we can use $(CENGINE) to make the container engine configurable. Signed-off-by: Sébastien Han <seb@redhat.com>
russellb
approved these changes
May 15, 2024
nathan-weinberg
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now 'make' checks for commands being present or not before running targets. It handles missing commands nicely.
Signed-off-by: Sébastien Han seb@redhat.com