Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

Fixes for linter in lab.py - #1162

Merged
mergify[bot] merged 1 commit into
instructlab:mainfrom
alimaredia:fix-pylint-5-14
May 15, 2024
Merged

Fixes for linter in lab.py#1162
mergify[bot] merged 1 commit into
instructlab:mainfrom
alimaredia:fix-pylint-5-14

Conversation

@alimaredia

Copy link
Copy Markdown
Contributor

Changes

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

@alimaredia
alimaredia force-pushed the fix-pylint-5-14 branch 2 times, most recently from 3490bd1 to 776da4e Compare May 14, 2024 23:34
Signed-off-by: Ali Maredia <amaredia@redhat.com>

@nathan-weinberg nathan-weinberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathan-weinberg

Copy link
Copy Markdown
Contributor

@Mergifyio backport release-v0.15

@mergify

mergify Bot commented May 15, 2024

Copy link
Copy Markdown
Contributor

backport release-v0.15

✅ Backports have been created

Details

@nathan-weinberg

Copy link
Copy Markdown
Contributor

@cdoern cdoern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cdoern

cdoern commented May 15, 2024

Copy link
Copy Markdown
Contributor

@instructlab/cli-maintainers PTAL

@cdoern

cdoern commented May 15, 2024

Copy link
Copy Markdown
Contributor

@russellb I think this is actually blocked via your pending review?

@leseb

leseb commented May 15, 2024

Copy link
Copy Markdown
Contributor

@russellb I think this is actually blocked via your pending review?

Indeed, do you have permission to dismiss @russellb's review? We already have two approvals.

@mergify
mergify Bot merged commit 7c7233d into instructlab:main May 15, 2024
mergify Bot added a commit that referenced this pull request May 15, 2024
…-1162

Fixes for linter in lab.py (backport #1162)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants