This repository was archived by the owner on Apr 23, 2026. It is now read-only.
fix: update make help text - #1172
Merged
Merged
Conversation
russellb
approved these changes
May 15, 2024
nathan-weinberg
force-pushed
the
make-help
branch
from
May 15, 2024 20:50
2250414 to
b73ea46
Compare
Contributor
Author
|
I rebased this on top of #1156 by @leseb and added some additional text there Development
tests Run tox -e unit against code
verify Run tox -e fmt,lint,spellcheck against code
spellcheck-sort Sort spellcheck directory
docs Run tox -e docs against code
md-lint Lint markdown files
Validation
check-tox ensure tox is installed
check-toolbox ensure toolbox is installed
check-engine ensure the container engine is installed
check-rocm ensure rocm is installed |
russellb
approved these changes
May 16, 2024
leseb
suggested changes
May 16, 2024
russellb
suggested changes
May 16, 2024
Added text for spellcheck-sort Moved md-lint into 'Development' section Added text for validation commands Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
nathan-weinberg
force-pushed
the
make-help
branch
from
May 16, 2024 16:28
a25032b to
369a76d
Compare
russellb
approved these changes
May 16, 2024
leseb
approved these changes
May 17, 2024
alimaredia
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of before/after below