Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

feat: Regenerate latest version of the client with field presence support - #401

Merged
vam-google merged 5 commits into
googleapis:diregapicfrom
vam-google:diregapic
May 10, 2021
Merged

feat: Regenerate latest version of the client with field presence support#401
vam-google merged 5 commits into
googleapis:diregapicfrom
vam-google:diregapic

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

No description provided.

@vam-google
vam-google requested a review from a team May 10, 2021 08:17
@product-auto-label product-auto-label Bot added the api: compute Issues related to the googleapis/java-compute API. label May 10, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml
  • .github/workflows/auto-release.yaml
  • .github/workflows/ci.yaml
  • .kokoro/build.sh
  • .kokoro/dependencies.sh
  • .kokoro/release/publish_javadoc.cfg
  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/snapshot.sh
  • .kokoro/release/stage.sh
  • LICENSE

@vam-google
vam-google requested a review from chingor13 May 10, 2021 08:19
…elist

This is totally expected, since it is an alpha client and both of those errors (`6003` - public constant value change, and `7012` - addition of a method to an interface) are expected given the underlying change. Specifially the `optional` keyword was added to `compute.proto`, which caused addition of `has<FieldName>()` methods to proto stubs and respective builders (error 7012). The field numbers change (error `6003`) was caused by the rollback of the previous hack (googleapis/googleapis-discovery#31) which, in its turn, was caused by a bug in protobuf.
@vam-google
vam-google requested a review from Neenu1995 May 10, 2021 17:13
@vam-google
vam-google merged commit 6e46502 into googleapis:diregapic May 10, 2021
Neenu1995 added a commit that referenced this pull request May 10, 2021
This pull request was generated using releasetool.

05-10-2021 16:14 PDT

chore: Update google-cloud-shared-dependencies dependency to 1.1.0 (#407)
feat: Regenerate latest version of the client with field presence support (#401)
test: commit integration tests by georgiyekkert (#319)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: compute Issues related to the googleapis/java-compute API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants