This repository was archived by the owner on Apr 12, 2022. It is now read-only.
chore: Update disco-to-proto3-converter with 2^29 as maximum field number - #31
Merged
Merged
Conversation
…mber. This is a rollback of googleapis/disco-to-proto3-converter#16, which became possible after protobuf fixed the original issue protocolbuffers/protobuf#8114
bshaffer
approved these changes
May 3, 2021
vchudnov-g
approved these changes
May 3, 2021
vam-google
added a commit
to vam-google/java-compute
that referenced
this pull request
May 10, 2021
…elist This is totally expected, since it is an alpha client and both of those errors (`6003` - public constant value change, and `7012` - addition of a method to an interface) are expected given the underlying change. Specifially the `optional` keyword was added to `compute.proto`, which caused addition of `has<FieldName>()` methods to proto stubs and respective builders (error 7012). The field numbers change (error `6003`) was caused by the rollback of the previous hack (googleapis/googleapis-discovery#31) which, in its turn, was caused by a bug in protobuf.
vam-google
added a commit
to googleapis/java-compute
that referenced
this pull request
May 10, 2021
…port (#401) Also add 7012 and 6003 backward compatibility check errors to ignorelist This is totally expected, since it is an alpha client and both of those errors (`6003` - public constant value change, and `7012` - addition of a method to an interface) are expected given the underlying change. Specifially the `optional` keyword was added to `compute.proto`, which caused addition of `has<FieldName>()` methods to proto stubs and respective builders (error 7012). The field numbers change (error `6003`) was caused by the rollback of the previous hack (googleapis/googleapis-discovery#31) which, in its turn, was caused by a bug in protobuf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rollback of googleapis/disco-to-proto3-converter#16, which became possible after protobuf fixed the original issue protocolbuffers/protobuf#8114