This repository was archived by the owner on Jul 15, 2024. It is now read-only.
test: commit integration tests by georgiyekkert - #319
Merged
gcf-merge-on-green[bot] merged 2 commits intoFeb 22, 2021
Conversation
chingor13
suggested changes
Feb 18, 2021
| @@ -0,0 +1,29 @@ | |||
| /* | |||
| * Copyright 2020 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2020 Google LLC | |
| * Copyright 2021 Google LLC |
Contributor
Author
There was a problem hiding this comment.
These files were actually created in 2020, that is why I decided to keep 2020. But ok, probably the year of the push must be the year.
|
|
||
| import static org.junit.Assert.fail; | ||
|
|
||
| import com.google.cloud.compute.v1.*; |
Contributor
There was a problem hiding this comment.
We shouldn't be using wildcard imports.
Contributor
Author
There was a problem hiding this comment.
Oh, yes, absolutely. Fixed.
| @@ -0,0 +1,116 @@ | |||
| /* | |||
| * Copyright 2020 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2020 Google LLC | |
| * Copyright 2021 Google LLC |
| */ | ||
| package com.google.cloud.compute.v1.integration; | ||
|
|
||
| import com.google.cloud.compute.v1.*; |
| @@ -0,0 +1,228 @@ | |||
| /* | |||
| * Copyright 2020 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2020 Google LLC | |
| * Copyright 2021 Google LLC |
|
|
||
| import com.google.api.gax.rpc.InvalidArgumentException; | ||
| import com.google.api.gax.rpc.NotFoundException; | ||
| import com.google.cloud.compute.v1.*; |
Contributor
Author
|
@chingor13 PTAL |
chingor13
approved these changes
Feb 22, 2021
This was referenced May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #290 overwriting history, since the original PR cannot be merged. Tests are by @georgiyekkert