[virtual-machine] Set PortList method by default - #996
Conversation
WalkthroughThis update increments the version numbers for the Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/apps/vm-instance/README.md (1)
42-42: Fix verb usage in description
The phrase “to passthrough the traffic” should use the verb form “pass through” instead of the noun “passthrough.”- specify method to passthrough the traffic to the virtual machine. + specify method to pass through the traffic to the virtual machine.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...externalMethod| specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/README.md (1)
42-42: Fix verb usage in description
The phrase “to passthrough the traffic” should be “to pass through the traffic” to correct the verb usage.- specify method to passthrough the traffic to the virtual machine. + specify method to pass through the traffic to the virtual machine.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/values.yaml (1)
4-4: Fix verb usage in comment
In the parameter description, “to passthrough the traffic” should be “to pass through the traffic” to use the correct verb form.- ## @param externalMethod specify method to passthrough the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList` + ## @param externalMethod specify method to pass through the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList`packages/apps/vm-instance/values.yaml (1)
4-4: Fix verb usage in comment
In the parameter description, change “to passthrough the traffic” to “to pass through the traffic” for correct verb usage.- ## @param externalMethod specify method to passthrough the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList` + ## @param externalMethod specify method to pass through the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
packages/apps/versions_map(2 hunks)packages/apps/virtual-machine/Chart.yaml(1 hunks)packages/apps/virtual-machine/README.md(1 hunks)packages/apps/virtual-machine/values.schema.json(1 hunks)packages/apps/virtual-machine/values.yaml(1 hunks)packages/apps/vm-instance/Chart.yaml(1 hunks)packages/apps/vm-instance/README.md(1 hunks)packages/apps/vm-instance/values.schema.json(1 hunks)packages/apps/vm-instance/values.yaml(1 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/apps/vm-instance/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ... externalMethod | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
🔇 Additional comments (12)
packages/apps/virtual-machine/Chart.yaml (2)
20-20: Bump chart version to 0.9.3
The chartversionhas been correctly incremented from 0.9.2 to 0.9.3 to reflect the new release.
26-26: Bump application version to 0.9.3
TheappVersionhas been updated in lockstep with the chart version. No additional adjustments required.packages/apps/vm-instance/README.md (1)
42-42: Update default passthrough method
The default forexternalMethodhas been changed fromWholeIPtoPortListin the documentation, aligning with the intended configuration update.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...externalMethod| specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/README.md (1)
42-42: Update default passthrough method
The documentation’s default forexternalMethodhas been updated fromWholeIPtoPortList, consistent with schema and values changes.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/values.yaml (1)
7-7: Update default externalMethod value
The defaultexternalMethodhas been updated toPortList, aligning with the chart and schema changes.packages/apps/vm-instance/values.yaml (1)
7-7: Update default externalMethod value
The defaultexternalMethodhas been changed toPortListto forward specific ports, consistent with the VM instance schema and documentation.packages/apps/vm-instance/Chart.yaml (2)
20-20: Approve version bump
The Helm chart version has been correctly incremented to 0.6.2 following semantic versioning.
26-26: Approve appVersion bump
The application version has been updated to 0.6.2 to match the chart version.packages/apps/vm-instance/values.schema.json (1)
13-13:Details
✅ Verification successful
Schema default updated to PortList
TheexternalMethoddefault value has been correctly changed from"WholeIP"to"PortList". Please verify that the corresponding default inpackages/apps/vm-instance/values.yamlis also updated to"PortList"to maintain consistency.To automate the check, you can run:
🏁 Script executed:
#!/bin/bash # Verify that values.yaml default for externalMethod matches the schema rg -n '"externalMethod":' packages/apps/vm-instance/values.yamlLength of output: 65
🏁 Script executed:
#!/bin/bash # Search for `externalMethod` in all YAML files under vm-instance to verify the default value fd -e yaml -e yml packages/apps/vm-instance | xargs rg -n 'externalMethod'Length of output: 2170
externalMethod default value is consistent
TheexternalMethoddefault inpackages/apps/vm-instance/values.yaml(line 7) is set toPortList, matching the updated schema. All defaults are in sync—approving these changes.packages/apps/versions_map (2)
162-162: Approve virtual-machine version mapping update
Thevirtual-machinecomponent has been updated to version 0.9.3 in the versions map.
173-173: Approve vm-instance version mapping update
Thevm-instancecomponent has been updated to version 0.6.2 in the versions map.packages/apps/virtual-machine/values.schema.json (1)
13-13:Details
✅ Verification successful
Schema default updated to PortList
TheexternalMethoddefault value has been correctly changed from"WholeIP"to"PortList". Please verify that the corresponding default inpackages/apps/virtual-machine/values.yamlis also updated to"PortList"to maintain consistency.To automate the check, you can run:
🏁 Script executed:
#!/bin/bash # Verify that values.yaml default for externalMethod matches the schema rg -n '"externalMethod":' packages/apps/virtual-machine/values.yamlLength of output: 69
To locate the
values.yamlfile and verify theexternalMethoddefault, let’s first confirm the file’s existence and then search for any occurrences project-wide:
🏁 Script executed:
#!/bin/bash # 1. List any values.yaml under virtual-machine find packages/apps/virtual-machine -type f -name "values.yaml" # 2. If that file exists, search within it for externalMethod if [ -f packages/apps/virtual-machine/values.yaml ]; then echo "Searching in packages/apps/virtual-machine/values.yaml:" rg -n 'externalMethod' packages/apps/virtual-machine/values.yaml || echo "– not found" else echo "packages/apps/virtual-machine/values.yaml not present" fi # 3. Search the entire repo for externalMethod to catch other locations echo "Searching across the repo for externalMethod:" rg -n 'externalMethod' || echo "– none found"Length of output: 2320
externalMethod default synchronized
Verified thatexternalMethodinpackages/apps/virtual-machine/values.yamlis set toPortList, matching the updated schema. All aligned.
c77e4d4 to
8f2eb5c
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/apps/vm-instance/README.md (1)
42-42: Confirm default change & refine wording. The default value forexternalMethodhas been correctly updated toPortList, matching the configuration changes. For improved clarity and correct verb usage, consider rephrasing “specify method to passthrough the traffic” to “specify the method to pass traffic through.”🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...externalMethod| specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/virtual-machine/README.md (1)
42-42: Update documentation style forexternalMethod.The default has correctly been changed to
PortListto match the schema and values updates. To maintain consistency and proper grammar, capitalize the imperative and use “pass through” instead of “passthrough”. For example:-| `externalMethod` | specify method to passthrough the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList` | `PortList` | +| `externalMethod` | Specify method to pass traffic through to the virtual machine. Allowed values: `WholeIP` and `PortList` | `PortList` |🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
packages/apps/versions_map(3 hunks)packages/apps/virtual-machine/Chart.yaml(1 hunks)packages/apps/virtual-machine/Makefile(1 hunks)packages/apps/virtual-machine/README.md(1 hunks)packages/apps/virtual-machine/values.schema.json(1 hunks)packages/apps/virtual-machine/values.yaml(1 hunks)packages/apps/vm-instance/Chart.yaml(1 hunks)packages/apps/vm-instance/Makefile(1 hunks)packages/apps/vm-instance/README.md(1 hunks)packages/apps/vm-instance/values.schema.json(1 hunks)packages/apps/vm-instance/values.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/apps/virtual-machine/Makefile
- packages/apps/virtual-machine/Chart.yaml
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/apps/vm-instance/values.yaml
- packages/apps/virtual-machine/values.yaml
- packages/apps/vm-instance/values.schema.json
- packages/apps/virtual-machine/values.schema.json
- packages/apps/versions_map
- packages/apps/vm-instance/Chart.yaml
🧰 Additional context used
🪛 LanguageTool
packages/apps/virtual-machine/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
packages/apps/vm-instance/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ... externalMethod | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
🔇 Additional comments (1)
packages/apps/vm-instance/Makefile (1)
12-12: ReorderexternalMethodenum values. The enumeration is correctly updated to["PortList", "WholeIP"], aligning the schema order with the new default.
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
8f2eb5c to
461f756
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/apps/virtual-machine/README.md (1)
42-42: Fix verb usage and capitalization in the descriptionThe table description should start with a capital letter and use the verb form “pass through” instead of the noun “passthrough.”
Proposed diff:
-| `externalMethod` | specify method to passthrough the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList` | `PortList` | +| `externalMethod` | Specify method to pass through the traffic to the virtual machine. Allowed values: `WholeIP` and `PortList` | `PortList` |🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
packages/apps/vm-instance/README.md (1)
42-42: Nit: refine verb in description
In the description cell, consider changing “specify method to passthrough the traffic” to “specify method to pass through the traffic” for grammatical accuracy.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...externalMethod| specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
packages/apps/versions_map(2 hunks)packages/apps/virtual-machine/Chart.yaml(1 hunks)packages/apps/virtual-machine/Makefile(1 hunks)packages/apps/virtual-machine/README.md(1 hunks)packages/apps/virtual-machine/values.schema.json(1 hunks)packages/apps/virtual-machine/values.yaml(1 hunks)packages/apps/vm-instance/Chart.yaml(1 hunks)packages/apps/vm-instance/Makefile(1 hunks)packages/apps/vm-instance/README.md(1 hunks)packages/apps/vm-instance/values.schema.json(1 hunks)packages/apps/vm-instance/values.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/apps/virtual-machine/Makefile
- packages/apps/virtual-machine/Chart.yaml
- packages/apps/virtual-machine/values.yaml
- packages/apps/vm-instance/values.yaml
- packages/apps/vm-instance/Makefile
- packages/apps/versions_map
- packages/apps/virtual-machine/values.schema.json
- packages/apps/vm-instance/values.schema.json
- packages/apps/vm-instance/Chart.yaml
🧰 Additional context used
🪛 LanguageTool
packages/apps/virtual-machine/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...nalMethod` | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
packages/apps/vm-instance/README.md
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ... externalMethod | specify method to passthrough the traffic to the virtual machine. All...
(NOUN_VERB_CONFUSION)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
🔇 Additional comments (1)
packages/apps/vm-instance/README.md (1)
42-42: Align default externalMethod with configuration changes
The default value forexternalMethodhas been correctly updated toPortList, matching the schema andvalues.yaml. This keeps the documentation in sync with the implementation.🧰 Tools
🪛 LanguageTool
[grammar] ~42-~42: The word “passthrough” is a noun. The verb is spelled with a white space.
Context: ...externalMethod| specify method to passthrough the traffic to the virtual machine. All...(NOUN_VERB_CONFUSION)
Specifically, update changes from - clickhouse: cozystack/cozystack#1059 - kafka: cozystack/cozystack#1040 - kubernetes: cozystack/cozystack#969 - tenant: cozystack/cozystack#980 - virtual-machine: cozystack/cozystack#996 - vm-instance: cozystack/cozystack#996 Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Specifically, update changes from - clickhouse: cozystack/cozystack#1059 - kafka: cozystack/cozystack#1040 - kubernetes: cozystack/cozystack#969 - tenant: cozystack/cozystack#980 - virtual-machine: cozystack/cozystack#996 - vm-instance: cozystack/cozystack#996 Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Signed-off-by: Andrei Kvapil kvapss@gmail.com
Summary by CodeRabbit
New Features
Documentation
Chores