Skip to content

[kafka] specify mimimal working resource presets - #1040

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix/kafka
Jun 9, 2025
Merged

[kafka] specify mimimal working resource presets#1040
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix/kafka

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Jun 9, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

  • New Features
    • Updated default resource presets for Kafka (now "small") and ZooKeeper (now "micro") to provide improved baseline resources.
  • Documentation
    • Updated documentation to reflect new default resource presets for Kafka and ZooKeeper.
  • Chores
    • Incremented Kafka chart version to 0.6.1 and updated version mapping.

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Resource preset defaults for Kafka and ZooKeeper were updated from "nano" to higher presets in the Helm chart, documentation, and schema files. The chart version was incremented from 0.6.0 to 0.6.1, and the versions map was updated to reflect the new version and commit associations.

Changes

Files/Group Change Summary
packages/apps/kafka/Chart.yaml Chart version incremented from 0.6.0 to 0.6.1.
packages/apps/kafka/README.md Updated default values for kafka.resourcesPreset (nano→small) and zookeeper.resourcesPreset (nano→micro) in documentation.
packages/apps/kafka/values.schema.json Changed default resourcesPreset for Kafka (nano→small) and ZooKeeper (nano→micro) in JSON schema.
packages/apps/kafka/values.yaml Updated resourcesPreset for Kafka (nano→small) and ZooKeeper (nano→micro) in configuration.
packages/apps/versions_map Updated Kafka version 0.6.0 to point to a specific commit; added 0.6.1 pointing to HEAD.

Suggested labels

enhancement, size:S, lgtm

Poem

A hop, a skip, a preset switch,
Kafka and ZooKeeper got a pitch!
From nano to small, and micro too,
Their resources grew, as bunnies do.
With versions bumped and docs in tune,
This chart’s improved—oh, what a boon!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c467ed7 and ba97a45.

📒 Files selected for processing (5)
  • packages/apps/kafka/Chart.yaml (1 hunks)
  • packages/apps/kafka/README.md (1 hunks)
  • packages/apps/kafka/values.schema.json (2 hunks)
  • packages/apps/kafka/values.yaml (2 hunks)
  • packages/apps/versions_map (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build
  • GitHub Check: pre-commit
🔇 Additional comments (8)
packages/apps/kafka/Chart.yaml (1)

19-19: Approve chart version bump.

The update from 0.6.0 to 0.6.1 follows semantic versioning and aligns with the resource preset changes in the chart.

packages/apps/versions_map (1)

42-43:

Details

✅ Verification successful

Verify Kafka version mapping.

You’ve pinned kafka 0.6.0 to commit 6130f43d and introduced 0.6.1 at HEAD. Ensure that:

  1. 6130f43d accurately corresponds to the last commit where Chart.yaml was at 0.6.0.
  2. No intermediate Kafka versions are missing in the map.

🏁 Script executed:

#!/bin/bash
# Verify that the commit hash for kafka 0.6.0 matches the Chart.yaml version
if git show 6130f43d:packages/apps/kafka/Chart.yaml | grep -q 'version: 0.6.0'; then
  echo "✅ Hash matches Chart version 0.6.0"
else
  echo "❌ Hash does not match Chart version 0.6.0"
  exit 1
fi

Length of output: 156


🏁 Script executed:

#!/bin/bash
# List all historical versions in packages/apps/kafka/Chart.yaml
git log --pretty=format:%H -- packages/apps/kafka/Chart.yaml | while read commit; do
  git show "$commit:packages/apps/kafka/Chart.yaml" 2>/dev/null \
    | grep '^version:' \
    | awk '{print $2}'
done | sort -u

Length of output: 287


🏁 Script executed:

#!/bin/bash
# Correctly list all unique versions from the history of packages/apps/kafka/Chart.yaml
git log --pretty=format:%H -- packages/apps/kafka/Chart.yaml | while read commit; do
  git show "${commit}:packages/apps/kafka/Chart.yaml" 2>/dev/null \
    | sed -n 's/^version:[[:space:]]*//p'
done | sort -u

Length of output: 287


🏁 Script executed:

#!/bin/bash
# Locate all Chart.yaml files in the repository (case-insensitive)
find . -type f -iname chart.yaml

Length of output: 7035


🏁 Script executed:

#!/bin/bash
# Accurately list all unique Kafka versions from the history of packages/apps/kafka/Chart.yaml
git rev-list HEAD -- packages/apps/kafka/Chart.yaml | while IFS= read -r commit; do
  git show "${commit}:packages/apps/kafka/Chart.yaml" 2>/dev/null \
    | sed -n 's/^version:[[:space:]]*//p'
done | sort -u

Length of output: 2340


Kafka version mapping verified

Commit 6130f43 correctly pins Chart.yaml to version 0.6.0, and the version history (0.1.0 → … → 0.6.0 → 0.6.1) shows no missing intermediate Kafka releases. All looks good.

packages/apps/kafka/values.yaml (2)

28-28: Approve Kafka resourcesPreset default update.

Changing kafka.resourcesPreset from "nano" to "small" raises the baseline resources to better suit production workloads.


45-45: Approve ZooKeeper resourcesPreset default update.

Updating zookeeper.resourcesPreset from "nano" to "micro" provides a more resilient default configuration.

packages/apps/kafka/README.md (2)

17-17: Approve Kafka docs default update.

Documentation now correctly reflects kafka.resourcesPreset: small, matching the Helm chart defaults.


19-19: Approve ZooKeeper docs default update.

The zookeeper.resourcesPreset default is updated to micro, in sync with values.yaml.

packages/apps/kafka/values.schema.json (2)

36-36: Approve Kafka schema default update.

The JSON schema default for kafka.resourcesPreset is now "small", consistent with the Helm values.


66-66: Approve ZooKeeper schema default update.

The JSON schema default for zookeeper.resourcesPreset is updated to "micro", aligning with the chart defaults.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps Andrei Kvapil (kvaps) added the backport Should change be backported on previous release label Jun 9, 2025
@kvaps
Andrei Kvapil (kvaps) merged commit 96506c7 into main Jun 9, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the fix/kafka branch June 9, 2025 22:34
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown

Successfully created backport PR for release-0.31:

@NickVolynkin Nick Volynkin (NickVolynkin) mentioned this pull request Jun 16, 2025
8 tasks
Andrei Kvapil (kvaps) added a commit that referenced this pull request Jun 16, 2025
…ets (#1041)

# Description
Backport of #1040 to `release-0.31`.
Nick Volynkin (NickVolynkin) added a commit to cozystack/website that referenced this pull request Jun 17, 2025
Specifically, update changes from
- clickhouse:      cozystack/cozystack#1059
- kafka:           cozystack/cozystack#1040
- kubernetes:      cozystack/cozystack#969
- tenant:          cozystack/cozystack#980
- virtual-machine: cozystack/cozystack#996
- vm-instance:     cozystack/cozystack#996

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Nick Volynkin (NickVolynkin) added a commit to cozystack/website that referenced this pull request Jun 17, 2025
Specifically, update changes from
- clickhouse:      cozystack/cozystack#1059
- kafka:           cozystack/cozystack#1040
- kubernetes:      cozystack/cozystack#969
- tenant:          cozystack/cozystack#980
- virtual-machine: cozystack/cozystack#996
- vm-instance:     cozystack/cozystack#996

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Should change be backported on previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant