Skip to content

[docs] Review the Clickhouse app docs - #1059

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
clickhouse-readme-review
Jun 16, 2025
Merged

[docs] Review the Clickhouse app docs#1059
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
clickhouse-readme-review

Conversation

@NickVolynkin

@NickVolynkin Nick Volynkin (NickVolynkin) commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Improved and clarified documentation for the Managed ClickHouse Service, including enhanced introductory content and clearer backup instructions.
    • Updated and corrected parameter descriptions for accuracy, especially regarding shards, replicas, storage sizes, and backup options.
    • Expanded explanations and examples for resource configuration in production environments.
    • Reformatted tables and notes for better readability and usability.

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This update revises the documentation and inline comments for the Managed Clickhouse Service Helm chart. It clarifies and corrects parameter descriptions in the README, schema, and values files, particularly regarding shards, replicas, storage, backup, and resource settings. No functional or structural changes to code or configuration were made.

Changes

File(s) Change Summary
.../clickhouse/README.md Enhanced introductory content, reformatted backup instructions, updated links, clarified parameter tables, and added resource configuration notes.
.../clickhouse/values.schema.json Refined property descriptions for clarity and accuracy, especially for storage, backup, shards, and replicas.
.../clickhouse/values.yaml Improved and corrected inline documentation comments for parameters, especially for storage, backup, and resources.

Suggested labels

enhancement, size:M, lgtm

Suggested reviewers

  • lllamnyp
  • klinch0

Poem

In the warren where Clickhouse hops,
Docs are polished, clarity tops!
Shards and replicas in neat array,
Backups explained the rabbit way.
Resource notes for every bunny,
Now reading docs is bright and sunny!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (12)
packages/apps/clickhouse/values.yaml (4)

3-6: Unify product casing: “ClickHouse” vs “Clickhouse”
The inline docs for shards and replicas use “Clickhouse,” but the official name is ClickHouse. Please update both descriptions to ClickHouse.


32-39: Recommend secure handling of backup credentials
Storing S3 access/secret keys and the Restic password directly in values.yaml poses a security risk. Advise users to inject these sensitive values via Kubernetes Secrets or Helm Secret plugins instead of embedding them in plain text.


50-52: Unify product casing: “ClickHouse”
The description for resources refers to “the Clickhouse service.” Please change it to ClickHouse for consistency.


60-62: Consider listing allowed resourcesPreset values
For clarity, you could enumerate the supported presets (none, nano, micro, small, medium, large, xlarge, 2xlarge) in the doc comment for resourcesPreset.

packages/apps/clickhouse/values.schema.json (3)

15-23: Unify product casing: “ClickHouse” vs “Clickhouse”
The JSON schema descriptions for both shards and replicas refer to Clickhouse. Update them to ClickHouse to match official naming.


82-84: Unify product casing: “ClickHouse”
The description for resources currently reads “Clickhouse service.” Please update it to ClickHouse for consistency.


85-89: Enforce valid resourcesPreset values via JSON Schema
To validate the resourcesPreset field, consider adding an enum with the allowed values:

"resourcesPreset": {
  "type": "string",
  "description": "Use a common resources preset when `resources` is not set explicitly.",
  "enum": ["none","nano","micro","small","medium","large","xlarge","2xlarge"],
  "default": "nano"
}
packages/apps/clickhouse/README.md (5)

3-6: Improve grammar and article usage in introduction

  • Hyphenate “open-source” and add commas for readability.
  • Include “the” before “Cozystack platform” and capitalize “Operator.”
    Example:
- ClickHouse is an open source high-performance and column-oriented SQL database management system (DBMS).
+ ClickHouse is an open-source, high-performance, column-oriented SQL database management system (DBMS).
- Cozystack platform uses Altinity operator to provide ClickHouse.
+ The Cozystack platform uses the Altinity Operator to provide ClickHouse.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~4-~4: You might be missing the article “the” here.
Context: ...or online analytical processing (OLAP). Cozystack platform uses Altinity operator to prov...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


7-7: Fix heading level and remove trailing colon
Change ### How to restore backup: to:

## How to restore backup

This restores proper heading hierarchy and removes the unnecessary colon.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

7-7: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)


7-7: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)


10-12: Specify language for fenced code blocks
Add a language identifier (e.g., bash) to both Restic command blocks:

- ```
+ ```bash

Also applies to: 15-17

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

10-10: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


25-32: Unify product casing in parameter table
In the “Common parameters” table, update all instances of Clickhouse to ClickHouse, especially for shards and replicas.


52-53: Separate resource parameters into their own table
The resources and resourcesPreset rows are currently under "Backup parameters." For clarity, move them into a dedicated "Resource parameters" section/table.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8eabe30 and 980185c.

📒 Files selected for processing (3)
  • packages/apps/clickhouse/README.md (2 hunks)
  • packages/apps/clickhouse/values.schema.json (3 hunks)
  • packages/apps/clickhouse/values.yaml (4 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/apps/clickhouse/README.md

[uncategorized] ~4-~4: You might be missing the article “the” here.
Context: ...or online analytical processing (OLAP). Cozystack platform uses Altinity operator to prov...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

🪛 markdownlint-cli2 (0.17.2)
packages/apps/clickhouse/README.md

7-7: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)


7-7: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)


10-10: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)


15-15: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build

Comment on lines -26 to -27
| `shards` | Number of Clickhouse replicas | `1` |
| `replicas` | Number of Clickhouse shards | `2` |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the initial reason for the PR: shards were explained as replicas and vice versa.

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickVolynkin Nick Volynkin (NickVolynkin) added the backport Should change be backported on previous release label Jun 16, 2025
@NickVolynkin Nick Volynkin (NickVolynkin) mentioned this pull request Jun 16, 2025
8 tasks
@kvaps
Andrei Kvapil (kvaps) merged commit 255fa8c into main Jun 16, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the clickhouse-readme-review branch June 16, 2025 16:14
@github-actions

Copy link
Copy Markdown

Successfully created backport PR for release-0.31:

Andrei Kvapil (kvaps) added a commit that referenced this pull request Jun 16, 2025
Nick Volynkin (NickVolynkin) added a commit to cozystack/website that referenced this pull request Jun 17, 2025
Specifically, update changes from
- clickhouse:      cozystack/cozystack#1059
- kafka:           cozystack/cozystack#1040
- kubernetes:      cozystack/cozystack#969
- tenant:          cozystack/cozystack#980
- virtual-machine: cozystack/cozystack#996
- vm-instance:     cozystack/cozystack#996

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Nick Volynkin (NickVolynkin) added a commit to cozystack/website that referenced this pull request Jun 17, 2025
Specifically, update changes from
- clickhouse:      cozystack/cozystack#1059
- kafka:           cozystack/cozystack#1040
- kubernetes:      cozystack/cozystack#969
- tenant:          cozystack/cozystack#980
- virtual-machine: cozystack/cozystack#996
- vm-instance:     cozystack/cozystack#996

Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Should change be backported on previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants