[docs] Review the Clickhouse app docs - #1059
Conversation
Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
WalkthroughThis update revises the documentation and inline comments for the Managed Clickhouse Service Helm chart. It clarifies and corrects parameter descriptions in the README, schema, and values files, particularly regarding shards, replicas, storage, backup, and resource settings. No functional or structural changes to code or configuration were made. Changes
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (12)
packages/apps/clickhouse/values.yaml (4)
3-6: Unify product casing: “ClickHouse” vs “Clickhouse”
The inline docs forshardsandreplicasuse “Clickhouse,” but the official name is ClickHouse. Please update both descriptions toClickHouse.
32-39: Recommend secure handling of backup credentials
Storing S3 access/secret keys and the Restic password directly invalues.yamlposes a security risk. Advise users to inject these sensitive values via Kubernetes Secrets or Helm Secret plugins instead of embedding them in plain text.
50-52: Unify product casing: “ClickHouse”
The description forresourcesrefers to “the Clickhouse service.” Please change it to ClickHouse for consistency.
60-62: Consider listing allowedresourcesPresetvalues
For clarity, you could enumerate the supported presets (none,nano,micro,small,medium,large,xlarge,2xlarge) in the doc comment forresourcesPreset.packages/apps/clickhouse/values.schema.json (3)
15-23: Unify product casing: “ClickHouse” vs “Clickhouse”
The JSON schema descriptions for bothshardsandreplicasrefer toClickhouse. Update them to ClickHouse to match official naming.
82-84: Unify product casing: “ClickHouse”
The description forresourcescurrently reads “Clickhouse service.” Please update it to ClickHouse for consistency.
85-89: Enforce validresourcesPresetvalues via JSON Schema
To validate theresourcesPresetfield, consider adding anenumwith the allowed values:"resourcesPreset": { "type": "string", "description": "Use a common resources preset when `resources` is not set explicitly.", "enum": ["none","nano","micro","small","medium","large","xlarge","2xlarge"], "default": "nano" }packages/apps/clickhouse/README.md (5)
3-6: Improve grammar and article usage in introduction
- Hyphenate “open-source” and add commas for readability.
- Include “the” before “Cozystack platform” and capitalize “Operator.”
Example:- ClickHouse is an open source high-performance and column-oriented SQL database management system (DBMS). + ClickHouse is an open-source, high-performance, column-oriented SQL database management system (DBMS). - Cozystack platform uses Altinity operator to provide ClickHouse. + The Cozystack platform uses the Altinity Operator to provide ClickHouse.🧰 Tools
🪛 LanguageTool
[uncategorized] ~4-~4: You might be missing the article “the” here.
Context: ...or online analytical processing (OLAP). Cozystack platform uses Altinity operator to prov...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
7-7: Fix heading level and remove trailing colon
Change### How to restore backup:to:## How to restore backupThis restores proper heading hierarchy and removes the unnecessary colon.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
7-7: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3(MD001, heading-increment)
7-7: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
10-12: Specify language for fenced code blocks
Add a language identifier (e.g.,bash) to both Restic command blocks:- ``` + ```bashAlso applies to: 15-17
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
10-10: Fenced code blocks should have a language specified
null(MD040, fenced-code-language)
25-32: Unify product casing in parameter table
In the “Common parameters” table, update all instances ofClickhouseto ClickHouse, especially forshardsandreplicas.
52-53: Separate resource parameters into their own table
TheresourcesandresourcesPresetrows are currently under "Backup parameters." For clarity, move them into a dedicated "Resource parameters" section/table.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/apps/clickhouse/README.md(2 hunks)packages/apps/clickhouse/values.schema.json(3 hunks)packages/apps/clickhouse/values.yaml(4 hunks)
🧰 Additional context used
🪛 LanguageTool
packages/apps/clickhouse/README.md
[uncategorized] ~4-~4: You might be missing the article “the” here.
Context: ...or online analytical processing (OLAP). Cozystack platform uses Altinity operator to prov...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
packages/apps/clickhouse/README.md
7-7: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
7-7: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
10-10: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
15-15: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
| | `shards` | Number of Clickhouse replicas | `1` | | ||
| | `replicas` | Number of Clickhouse shards | `2` | |
There was a problem hiding this comment.
This is the initial reason for the PR: shards were explained as replicas and vice versa.
|
Successfully created backport PR for |
# Description Backport of #1059 to `release-0.31`.
Specifically, update changes from - clickhouse: cozystack/cozystack#1059 - kafka: cozystack/cozystack#1040 - kubernetes: cozystack/cozystack#969 - tenant: cozystack/cozystack#980 - virtual-machine: cozystack/cozystack#996 - vm-instance: cozystack/cozystack#996 Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Specifically, update changes from - clickhouse: cozystack/cozystack#1059 - kafka: cozystack/cozystack#1040 - kubernetes: cozystack/cozystack#969 - tenant: cozystack/cozystack#980 - virtual-machine: cozystack/cozystack#996 - vm-instance: cozystack/cozystack#996 Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>
Summary by CodeRabbit