Minor tag & addon group, separate forums addon group in settings page - #3261
Minor tag & addon group, separate forums addon group in settings page#3261WorldLanguages wants to merge 4 commits into
Conversation
|
1.19.0 will add many "minor" addons (I think about 3) so let's try to get this merged |
|
I don't think "small" (wouldn't just "small" be a better name for the group?) and "others" should be separated. Small features can be very useful and we shouldn't have to hide them if we want to be consistent. How does this affect the state of #2908? |
|
Then which addons are Easter eggs now?
…________________________________
From: World_Languages ***@***.***>
Sent: Sunday, August 8, 2021 1:53:15 PM
To: ScratchAddons/ScratchAddons ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [ScratchAddons/ScratchAddons] Minor tag & addon group, separate forums addon group in settings page (#3261)
Resolves #2617<#2617>
Resolves #3155<#3155> (renames my-ocular addon exactly as that PR does)
* Creates "minor" tag
* Creates addon group for "minor" tag, named "small features". The group is below the "others" group and collapsed on page load.
* Create dedicated group for disabled non-recommended forum addons. The group is above the "others" group, but collapsed on page load. We could consider expanding it on page load, but I'm not sure.
* Rename ocular addon after compromise suggested by mxmou here: #3155 (comment)<#3155 (comment)>
All changes to addons:
* Capitalized Account Settings: remove easter egg, add minor tag
* Better emojis: add minor tag, moved from "others" group to "small features" group
* Front page curator link: add minor tag, moved from "others" group to "small features" group
* Customizable profile picture border: add minor tag, moved from "new" group to "small features" group (would have been inside "others" group if the addon wasn't new)
* SVG uploads fixed: moved from "others" group to "small features" group. This addon technically fixes a Scratch bug, but it only happens with SVG files uploaded with very specific software.
* Rename my ocular addon, from ocular.jeffalo.net integration to ocular integration
* Redirect to standard forums: remove easter egg, keep forums tag, moved from easter egg status to "forums" group
* Remove curved stage border: moved from "others" group to "small features" group
* Semicolon glitch: removed easter egg, add minor tag
________________________________
You can view, comment on, or merge this pull request online at:
#3261
Commit Summary
* Create groups for forums and minor addons
* Add minor tag to some addons
* Rename to "ocular integration"
* Remove easterEgg tag from redirect-mobile-forums
File Changes
* M _locales/en/messages.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-4362c7f7032e9687a0a5910cadc127afbe8259b2b941de40dd4246c35b1446f0> (4)
* M addons/account-settings-capitalize/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-e6e4a28707e11b3b8b6e2f92778bd3f7927d715b912cf551c523d120b7b0bad1> (2)
* M addons/better-emojis/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-074d74ad777784cfc326a020a8bc045b59e167d9f2b29138e70e9fdfb6104959> (2)
* M addons/curator-link/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-72ce7c40a8fe4ddd78c268e2ae51b204ffffe0f45d06980b36bf2aaa0fd9c1cd> (2)
* M addons/customize-avatar-border/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-22e9fec3293fe0ede65e761e3884ba2c9faa87e70a59213cc2f37d97c9052e62> (2)
* M addons/fix-uploaded-svgs/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-3893773c1feab20eddc19935f6b0df645ac6705a5fffddf2c5d43d516551aa67> (2)
* M addons/my-ocular/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-d3e0d8bc749050f062e0c5445565628b2d081b4562e200388b8f43b1a307be53> (2)
* M addons/redirect-mobile-forums/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-65745fd2732af2a4e31bc6760fa27d8dbcc49ae67554030ce5b925a71e44b8fa> (2)
* M addons/remove-curved-stage-border/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-79c8064cb0527ff25cf713aeabe6923a72e3a4f8941e47e607a5a77df8fa9482> (2)
* M addons/semicolon/addon.json<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-01ef5f33d19b85a05c73189beb5f2868f89560bedc7d1845cd6c9ed1614172e1> (2)
* M webpages/settings/data/addon-groups.js<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-ada5a2a719af1a479d6f5d083315939036b2eeff160258ae9278a5eafa0c2117> (16)
* M webpages/settings/index.js<https://github.com/ScratchAddons/ScratchAddons/pull/3261/files#diff-716aae76bfb4eaa095810abaddc214bb23abc4a9ddc232f27cb3203233c1c0da> (2)
Patch Links:
* https://github.com/ScratchAddons/ScratchAddons/pull/3261.patch
* https://github.com/ScratchAddons/ScratchAddons/pull/3261.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#3261>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DEX3GDDHPNJQU5WV243T33HBXANCNFSM5BYYD5EA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
|
I don't think minor tags are useful that much; are they problematic if they stay like now? |
Maybe
So your point is what exactly? That the "small" group should be expanded on page load?
Well, I wouldn't like to see "user ID" addon under "others". It makes no sense to have "clone counter" and "user ID" in the same group, there's a big difference in usefulness. 99% of people wouldn't use the user ID addon. And hiding it as an easter egg is too extreme. |
That it shouldn't be a separate group at all.
Wouldn't adding the featured tag and making clone counter featured solve this too? |
|
Hmm yeah. I guess what we really want is avoid having so many addons inside the "other" group. Some ways to achieve that:
@mxmou So you want to do first two only? |
|
Yeah, why not categorize non-minor addons first? |
|
Well does someone else want to PR "featured" tag and group? I don't really want to PR something like this for the third time :P |
What happened to #2908? |
|
Lol good point 🤦 |
Resolves #2617
Resolves #3155 (renames my-ocular addon exactly as that PR does)
All changes to addons:
ocular.jeffalo.net integrationtoocular integration