Skip to content

User-ID - #3176

Merged
WorldLanguages merged 20 commits into
ScratchAddons:masterfrom
LankyBox01:CodeGuy92-user
Aug 15, 2021
Merged

User-ID#3176
WorldLanguages merged 20 commits into
ScratchAddons:masterfrom
LankyBox01:CodeGuy92-user

Conversation

@LankyBox01

@LankyBox01 LankyBox01 commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

Resolves #3166

Changes

I left comments.
All i need now is versionAdded, Credits, and some other stuff for addon.json
image

Reason for changes

#3166

Tests

#3166 (comment)
To test this locally, click this: https://github.com/CodeGuy92/ScratchAddons/archive/refs/heads/CodeGuy92-user.zip

@FunctionalMetatable

FunctionalMetatable commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

Resolves #3166 <- put this in pr post

@LankyBox01

Copy link
Copy Markdown
Contributor Author

Resolves #3166 <- put this in pr post

Ok

Comment thread addons/user-id/addon.json
Comment thread addons/user-id/userscript.js Outdated
Co-authored-by: FunctionalMetatable <67440879+FunctionalMetatable@users.noreply.github.com>
Comment thread addons/user-id/userscript.js Outdated
LankyBox01 and others added 2 commits July 31, 2021 15:10
Co-authored-by: FunctionalMetatable <67440879+FunctionalMetatable@users.noreply.github.com>
@cobaltt7

Copy link
Copy Markdown
Contributor

Enable actions at https://github.com/CodeGuy92/ScratchAddons/actions

Comment thread addons/user-id/userscript.js Outdated
Comment thread addons/user-id/userscript.js Outdated
@LankyBox01

Copy link
Copy Markdown
Contributor Author

Now it works, tests are still up-to-date

@LankyBox01

Copy link
Copy Markdown
Contributor Author

image

Comment thread addons/user-id/userscript.js Outdated

@FunctionalMetatable FunctionalMetatable left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
LGTM

@jeffalo

jeffalo commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

can the text be smaller?

@WorldLanguages

Copy link
Copy Markdown
Member

We probably need a "minor addons" category by now :P

@LankyBox01

Copy link
Copy Markdown
Contributor Author

can the text be smaller?

yea sure

We probably need a "minor addons" category by now :P

lool

@LankyBox01

Copy link
Copy Markdown
Contributor Author

image

Updated tests :)

@LankyBox01

Copy link
Copy Markdown
Contributor Author

127749724-85e51b98-948d-4649-8508-18899ae38155

@WorldLanguages

Copy link
Copy Markdown
Member

Waiting for #3261 to be merged

@LankyBox01

Copy link
Copy Markdown
Contributor Author

Waiting for #3261 to be merged

aight

@WorldLanguages
WorldLanguages merged commit 6ae614e into ScratchAddons:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New addon]: Show user id in profiles

6 participants