You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can deal on whether some addons should be enabled by default or not in a future PR, please leave that for the future.
Recommended tag has not changed - there are still many recommended addons that aren't enabled by default.
Whether an addon is recommended, featured, or none, is very opiniated. I suggest you avoid discussing addons that fall in a gray area. We'll soon have a source of truth for what addons people use because of #3283, so let's just wait until we can use that. In general, recommended addons should be those that more than 75% of users use, and featured ones should be idk, more than 20%? We'll see how it plays out.
Featured tag is not visible as a tag - it's only used for grouping. Because of this reason, forum tag (green background tag, not literal manifest tag) could be removed, sure (just noticed while writing this, after commiting)
Ocular addon was renamed per mxmou's suggestion #3155 (comment)
Some easter egg addons are now under "other" group
Clone counter is now recommended, it was previously under "others" group
For whole list of changes see changed files, I'll just list downgrades (addons that go from recommended to featured)
better-featured-project: I don't like recommended themes
custom-block-shape: let's try to keep 2.0 look addons under featured
dark-www: same as below
editor-dark-mode: same as better-featured-project. I didn't remove scratchr2 from recommended tho, because it brings consistency.
This is the amount of addons in each group on a fresh install (and making sure no addons fall inside "new", in other words, this is how v1.20.0 will look if it had no new addons on it)
Whether an addon is recommended, featured, or none, is very opiniated. I suggest you avoid discussing addons that fall in a gray area. We'll soon have a source of truth for what addons people use because of #3283, so let's just wait until we can use that. In general, recommended addons should be those that more than 75% of users use, and featured ones should be idk, more than 20%? We'll see how it plays out.
This doesn't make much sense. Recommended and featured addons should be addons we want people to use, not ones they already use.
This doesn't make much sense. Recommended and featured addons should be addons we want people to use, not ones they already use.
Well you've got a point, I made a little paradox hehe. Featured addons will naturally have more users because they are featured. So, let me rephrase.
If there's an addon under "others" that is widely used compared to other addons under that category, we should probably bump it to "featured".
And if an addon that has been featured for a while doesn't have many users, it can probably be put into "others".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, my 3rd PR :P
We can deal on whether some addons should be enabled by default or not in a future PR, please leave that for the future.
Recommended tag has not changed - there are still many recommended addons that aren't enabled by default.
Whether an addon is recommended, featured, or none, is very opiniated. I suggest you avoid discussing addons that fall in a gray area. We'll soon have a source of truth for what addons people use because of #3283, so let's just wait until we can use that. In general, recommended addons should be those that more than 75% of users use, and featured ones should be idk, more than 20%? We'll see how it plays out.
Featured tag is not visible as a tag - it's only used for grouping. Because of this reason, forum tag (green background tag, not literal manifest tag) could be removed, sure (just noticed while writing this, after commiting)
Ocular addon was renamed per mxmou's suggestion #3155 (comment)
Some easter egg addons are now under "other" group
Clone counter is now recommended, it was previously under "others" group
For whole list of changes see changed files, I'll just list downgrades (addons that go from recommended to featured)