Componentize the settings page - #2258
Merged
Merged
Conversation
21 tasks
Member
|
This is awesome! One thing I want to consider is figuring out how to have separate files for components. |
Member
Categories and icons |
Member
Keep in mind that a file with an inline |
| for (let child of this.$children) { | ||
| if (child.isOpen && child.canCloseOutside && e.isTrusted && child.color && child !== leaveOpen) { | ||
| child.toggle(child.addon, child.setting, false); | ||
| for (let addon of this.$children) { |
Member
There was a problem hiding this comment.
Maybe this.$children.filter(c => c.$options.name === "addon-body")
apple502j
added a commit
to apple502j/ScratchAddons
that referenced
this pull request
Apr 24, 2021
WorldLanguages
pushed a commit
that referenced
this pull request
Apr 24, 2021
* Fix lint * Fix typos in editor-devtools * Remove unused code for feedback * editor-devtools: change message for help * Remove unused strings * Remove dead code * Remove references to griffpatch * style: format code * editor-devtools: change some messages * Bump GH Actions deps * Fix typo * Fix lint error * Fix error caused by #2258 * style: format code Co-authored-by: apple502j <apple502j@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As of writing this, this PR converts the addon body and the addon settings into components.
Reason for changes
For organizations so functions for just settings or just addons stay in one place rather than with everything else. Also, so we don't have to pass in
addonorsettinginto functions.Tests
Probably needs more testing just in case.
Discuss
What else might need to be componentized?