Skip to content

Update all settings at once when loading presets - #2278

Merged
TheColaber merged 2 commits into
ScratchAddons:masterfrom
mxmou:presets-all-at-once
Apr 30, 2021
Merged

Update all settings at once when loading presets#2278
TheColaber merged 2 commits into
ScratchAddons:masterfrom
mxmou:presets-all-at-once

Conversation

@mxmou

@mxmou mxmou commented Apr 24, 2021

Copy link
Copy Markdown
Member

Resolves

Resolves #2177

Changes

Changes preset loading to update all settings at once.

@mxmou
mxmou requested a review from WorldLanguages as a code owner April 24, 2021 07:42
@apple502j apple502j added priority: 4 Low priority. Includes minor bugs and less important features scope: webpages Related to the web pages (settings page, pop-up, etc) labels Apr 24, 2021
@WorldLanguages

Copy link
Copy Markdown
Member

We should update all at once when resetting all to default
And fix some console logs that broke after #2258:
image

@TheColaber
TheColaber merged commit e731709 into ScratchAddons:master Apr 30, 2021
@mxmou
mxmou deleted the presets-all-at-once branch June 6, 2021 14:05
@mxmou
mxmou removed the request for review from WorldLanguages March 19, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: 4 Low priority. Includes minor bugs and less important features scope: webpages Related to the web pages (settings page, pop-up, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all settings at once when setting presets

4 participants