Skip to content

Settings page: add addon groups and subcategories - #2260

Merged
WorldLanguages merged 135 commits into
ScratchAddons:masterfrom
TheColaber:tag-time
May 2, 2021
Merged

Settings page: add addon groups and subcategories#2260
WorldLanguages merged 135 commits into
ScratchAddons:masterfrom
TheColaber:tag-time

Conversation

@TheColaber

@TheColaber TheColaber commented Apr 22, 2021 •
edited by WorldLanguages
Loading

Copy link
Copy Markdown
Member

Resolves #2218
Resolves #2281
Resolves #2303
Resolves #1505
TODOs

  • decide how to order each group
  • handle search with groups
  • handle hidden addons with groups (when searching)
  • css
  • not sure why everything has "for website" or "for editor" visible tag
  • handle small settings page in popup
  • bug: cannot close color pickers
  • disabled easter egg addons
  • "hidden" tag (same group as beta)
  • expanded should be a prop, not an addon prop
  • bug: beta group acts weird since it's default disabled
  • remove filters
  • subcategories
  • more tags and categories
  • location.hash with groups
  • different categories in iframe mode
  • Order when searching?
  • Consistent tag ordering
  • Delete "remove on v1.14.0" code
  • Fix being able to open color pickers when addon disabled
  • what to do with the emptyness when opening the popup

@TheColaber TheColaber added the status: pending A PR is still not ready to merge, or an issue is being worked on/on consideration label Apr 22, 2021
@TheColaber TheColaber mentioned this pull request Apr 24, 2021
Closed
@mxmou

mxmou commented Apr 25, 2021

Copy link
Copy Markdown
Member

Resolves #2218 and #2281?

@cobaltt7 cobaltt7 linked an issue Apr 25, 2021 that may be closed by this pull request
Addon Groups (minimizable) #2281
Closed
WorldLanguages
WorldLanguages reviewed Apr 25, 2021
View reviewed changes
Comment thread webpages/settings/index.js Outdated
WorldLanguages
WorldLanguages reviewed Apr 25, 2021
View reviewed changes
Comment thread webpages/settings/index.js
WorldLanguages
WorldLanguages reviewed Apr 25, 2021
View reviewed changes
Comment thread webpages/settings/index.js
@WorldLanguages

WorldLanguages commented Apr 25, 2021

Copy link
Copy Markdown
Member

Let's also call these groups instead of categories. Addons can be in more than 1 group, but can only have 1 category (editor, website, theme, extension popup feature)

@WorldLanguages

WorldLanguages commented May 2, 2021

Copy link
Copy Markdown
Member

IMO we shouldn't do subcategories in the first place....

Search filters please

We can always rectify in the future. Subcategories are still based on tags.
I plan to add search filters / advanced search next version. But subcategories seem like a good idea so that users can digest addons more slowly while exploring the settings page for the first time.

WorldLanguages
WorldLanguages reviewed May 2, 2021
View reviewed changes
Comment thread webpages/settings/index.js Outdated
@WorldLanguages WorldLanguages changed the title Rewrite tag system Settings page: add addon groups and subcategories May 2, 2021
@apple502j apple502j added priority: 2 High priority. Includes crashes, major bugs and important features scope: webpages Related to the web pages (settings page, pop-up, etc) and removed status: pending A PR is still not ready to merge, or an issue is being worked on/on consideration labels May 2, 2021
@WorldLanguages
WorldLanguages merged commit 5662bb0 into ScratchAddons:master May 2, 2021
@mxmou mxmou mentioned this pull request May 6, 2021
Closed
@TheColaber
TheColaber deleted the tag-time branch June 25, 2024 13:51
@Samq64 Samq64 mentioned this pull request Apr 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WorldLanguages WorldLanguages WorldLanguages left review comments
@mxmou mxmou mxmou left review comments
@apple502j apple502j Awaiting requested review from apple502j

Assignees

No one assigned

Labels

priority: 2 High priority. Includes crashes, major bugs and important features scope: webpages Related to the web pages (settings page, pop-up, etc)

Projects

None yet

Milestone

No milestone

8 participants

@TheColaber @mxmou @WorldLanguages @Hans5958 @Secret-chest @cobaltt7 @GrahamSH-LLK @apple502j