This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Clean cross-train config discovery code pieces - #1024
Merged
Fei Chen (feich-ms) merged 3 commits intoOct 20, 2020
Merged
Conversation
Fei Chen (feich-ms)
requested a review
from Emilio Munoz (munozemilio)
as a code owner
October 19, 2020 06:16
Dong Lei (boydc2014)
approved these changes
Oct 20, 2020
Fei Chen (feich-ms)
deleted the
feich/cleanCrossTrainConfigDiscoveryCodePieces
branch
October 20, 2020 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1016, #997, #998, #999. Clean all cross-train config discovery code pieces, that means there is config auto-discovery afterwards and --config is required when using cross-train cli.