Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

bf luis:cross-train creates invalid config internally #998

Description

Versions

4.10.1

Describe the bug

The code which generates a config by inspecting the file system doesn't generate the same data structure that the library that consumes is expecting.
in

in confighelp.js line 87

          result[key].triggers[trigger.intent] = relativePath

in crosstrain.js line 38

const {rootIds, triggerRules, intentName, verbose} = crossTrainConfig

You will see that the confighelper is creating a property called "triggers" while the library is expecting "triggerRules"

THIS LIBRARY SHOULD HAVE BEEN TYPESCRIPT, this bug could have happened if the config had an interface definition. There is a reason typescript exists and THIS IS IT.

[bug]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions