Create a safer abstraction for TypeAdapter validation by Copilot · Pull Request #1762 · usethis-python/usethis-python

Copilot · 2026-04-02T01:26:10Z

Skills used: usethis-qa-static-checks, usethis-github-issue-create

…r_default wrappers Migrate all direct TypeAdapter usage in business logic files to the new validate_or_raise and validate_or_default wrappers from usethis._validate. Updated files: - _file/pyproject_toml/name.py, project.py, deps.py, requires_python.py - _core/status.py - _tool/impl/base/ruff.py, deptry.py - _integrations/sonarqube/config.py - _backend/uv/deps.py Also added TID251 per-file-ignores for the I/O infrastructure files (ini/io_.py, toml/io_.py, yaml/io_.py) which use TypeAdapter extensively in their core dict-traversal logic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

…n file I/O managers Replace all direct pydantic TypeAdapter/ValidationError usage in toml/io_.py, yaml/io_.py, and ini/io_.py with the validate_or_raise wrapper from usethis._validate. - toml/io_.py: Replace TypeAdapter calls, catch TOMLValueInvalidError - yaml/io_.py: Replace TypeAdapter calls, catch UnexpectedYAMLValueError - ini/io_.py: Replace TypeAdapter calls with validate_or_raise - ruff.toml: Remove TID251 per-file-ignores for the three files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/be6062d4-5e4e-4744-9771-ce15eb74e895 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

codecov · 2026-04-02T21:06:29Z

Codecov Report

❌ Patch coverage is 98.29545% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/usethis/_file/yaml/io_.py	89.65%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-04-02T21:06:31Z

Merging this PR will not alter performance

✅ 3 untouched benchmarks

_{Comparing copilot/create-safer-abstraction-for-typeadapter-validatio (6f13a89) with main (fe3b8a6)}

…to KeyValueFileManager Per review feedback: - Move src/usethis/_validate.py -> src/usethis/_file/validate.py - Add get_validated(keys, *, default, validate=None) method - Add ensure_get(keys, *, err, validate) method - Replace direct validate_or_default usage in tool/core/backend files with the new file manager methods - Update .importlinter, tests, and generated docs Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/ae5b883a-a133-47ce-a8c8-86903ff6c49e Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/74ba0f75-c2cd-45aa-b890-dc8228ec2711 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/1564655d-dd00-4582-9f0f-e08225210e9e Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

… ensure_get/validated_get in pyproject_toml and sonarqube modules Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/1564655d-dd00-4582-9f0f-e08225210e9e Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

nathanjmcdougall · 2026-04-07T07:05:24Z

@copilot please pass static checks

…-substrings) Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/07093d4e-1e91-49fb-9686-b3e141b83d29 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot · 2026-04-07T07:09:17Z

@copilot please pass static checks

Fixed in 9bda459 — the check-docstring-substrings hook was catching a double backtick in hooks/export-functions.py:147. Changed @overload to `@overload`. All prek hooks and basedpyright now pass cleanly.

…pter-validatio

…move test class docstrings Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/690b9dc0-c97a-46d2-b952-6bf84cfe9131 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

…toml Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/20e757e7-c8ce-492d-a26d-a4b03ec79027 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

…t for invalid configs, remove unused SonarQubeError base class Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c1bb2774-9802-4976-9c81-851b72ce5735 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

…cted Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c1bb2774-9802-4976-9c81-851b72ce5735 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

…s still actively raised Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/2d2991c3-9149-42d5-962f-11a9b2a29d3a Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Initial plan

aec204e

Copilot AI assigned Copilot and nathanjmcdougall Apr 2, 2026

Copilot started work on behalf of nathanjmcdougall April 2, 2026 01:26 View session

Copilot AI linked an issue Apr 2, 2026 that may be closed by this pull request

Create a safer abstraction for TypeAdapter validation #1440

Open

Copilot AI and others added 4 commits April 2, 2026 01:48

Fix docstrings to use backtick quotes and sync generated docs

4e8938c

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/be6062d4-5e4e-4744-9771-ce15eb74e895 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Fix type errors, lint issues, and add tests for validate wrappers

eac98a7

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/be6062d4-5e4e-4744-9771-ce15eb74e895 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Create a safer abstraction for TypeAdapter validation~~ Create safer abstraction for TypeAdapter validation Apr 2, 2026

Copilot AI requested a review from nathanjmcdougall April 2, 2026 02:17

Copilot finished work on behalf of nathanjmcdougall April 2, 2026 02:17

nathanjmcdougall marked this pull request as ready for review April 2, 2026 21:01

Copilot AI temporarily deployed to codecov April 2, 2026 21:01 Inactive

nathanjmcdougall requested changes Apr 2, 2026

View reviewed changes

Comment thread src/usethis/_tool/impl/base/ruff.py Outdated

Copilot started work on behalf of nathanjmcdougall April 2, 2026 21:18 View session

Copilot AI requested a review from nathanjmcdougall April 2, 2026 21:28

Copilot finished work on behalf of nathanjmcdougall April 2, 2026 21:28

nathanjmcdougall requested changes Apr 3, 2026

View reviewed changes

Comment thread src/usethis/_backend/uv/deps.py Outdated

Copilot started work on behalf of nathanjmcdougall April 3, 2026 19:34 View session

Remove redundant KeyError handling around get_validated in uv/deps.py

d130b28

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/74ba0f75-c2cd-45aa-b890-dc8228ec2711 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot finished work on behalf of nathanjmcdougall April 3, 2026 19:36

Copilot AI requested a review from nathanjmcdougall April 3, 2026 19:36

nathanjmcdougall requested changes Apr 3, 2026

View reviewed changes

Comment thread src/usethis/_file/manager.py Outdated

Comment thread src/usethis/_file/ini/io_.py

Copilot started work on behalf of nathanjmcdougall April 3, 2026 20:13 View session

Copilot AI and others added 2 commits April 3, 2026 20:18

Plan for addressing review comments

16cd8a3

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/1564655d-dd00-4582-9f0f-e08225210e9e Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot started work on behalf of nathanjmcdougall April 7, 2026 07:05 View session

Fix double backtick in export-functions.py docstring (check-docstring…

9bda459

…-substrings) Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/07093d4e-1e91-49fb-9686-b3e141b83d29 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot finished work on behalf of nathanjmcdougall April 7, 2026 07:11

Copilot AI had a problem deploying to codecov April 7, 2026 07:13 Error

Merge branch 'main' into copilot/create-safer-abstraction-for-typeada…

2ffc4e5

…pter-validatio

nathanjmcdougall temporarily deployed to codecov April 7, 2026 07:16 — with GitHub Actions Inactive

nathanjmcdougall mentioned this pull request Apr 7, 2026

Support @overload in export-functions #1874

Closed

Copilot AI mentioned this pull request Apr 7, 2026

Support @overload in export-functions hook #1875

Merged

nathanjmcdougall requested changes Apr 8, 2026

View reviewed changes

Comment thread ruff.toml Outdated

Comment thread tests/usethis/_file/test_validate.py Outdated

Copilot started work on behalf of nathanjmcdougall April 8, 2026 02:47 View session

Copilot finished work on behalf of nathanjmcdougall April 8, 2026 02:57

Copilot AI requested a review from nathanjmcdougall April 8, 2026 02:57

Copilot AI temporarily deployed to codecov April 8, 2026 05:47 Inactive

Copilot started work on behalf of nathanjmcdougall April 8, 2026 05:48 View session

Use inline noqa: TID251 comments instead of per-file ignores in ruff.…

1d2bfda

…toml Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/20e757e7-c8ce-492d-a26d-a4b03ec79027 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot AI temporarily deployed to codecov April 8, 2026 05:52 Inactive

Copilot finished work on behalf of nathanjmcdougall April 8, 2026 05:52

nathanjmcdougall requested changes Apr 9, 2026

View reviewed changes

Comment thread src/usethis/_file/validate.py Outdated

Comment thread src/usethis/_file/validate.py Outdated

Comment thread src/usethis/_integrations/sonarqube/config.py

Comment thread src/usethis/_file/yaml/io_.py Outdated

Copilot started work on behalf of nathanjmcdougall April 9, 2026 20:34 View session

Copilot AI and others added 2 commits April 9, 2026 20:45

Improve test assertion to verify pydantic validation details are inje…

6f13a89

…cted Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c1bb2774-9802-4976-9c81-851b72ce5735 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot finished work on behalf of nathanjmcdougall April 9, 2026 20:49

Copilot AI requested a review from nathanjmcdougall April 9, 2026 20:49

Copilot AI temporarily deployed to codecov April 9, 2026 22:28 Inactive

Copilot started work on behalf of nathanjmcdougall April 9, 2026 22:30 View session

Copilot finished work on behalf of nathanjmcdougall April 9, 2026 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a safer abstraction for TypeAdapter validation#1762

Create a safer abstraction for TypeAdapter validation#1762
Copilot wants to merge 25 commits intomainfrom
copilot/create-safer-abstraction-for-typeadapter-validatio

Copilot AI commented Apr 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nathanjmcdougall commented Apr 7, 2026

Uh oh!

Copilot AI commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nathanjmcdougall commented Apr 7, 2026

Uh oh!

Copilot AI commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 2, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited

Loading

codspeed-hq bot commented Apr 2, 2026 •

edited

Loading