Skip to content

Support @overload in export-functions hook#1875

Merged
nathanjmcdougall merged 2 commits intomainfrom
copilot/support-overload-in-export-functions
Apr 8, 2026
Merged

Support @overload in export-functions hook#1875
nathanjmcdougall merged 2 commits intomainfrom
copilot/support-overload-in-export-functions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

The export-functions prek hook was including @overload-decorated function signatures in the exported function reference, producing duplicate entries for overloaded functions.

  • Add _is_overload helper that detects both @overload and @typing.overload decorator forms
  • Skip overloaded functions in _get_module_public_functions so only the implementation is exported
  • Add tests for both decorator styles

Copilot AI changed the title [WIP] Add support for @overload in export-functions Support @overload in export-functions hook Apr 7, 2026
Copilot AI requested a review from nathanjmcdougall April 7, 2026 22:03
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 7, 2026 22:18
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 7, 2026

Merging this PR will not alter performance

✅ 3 untouched benchmarks


Comparing copilot/support-overload-in-export-functions (b92a250) with main (3a899c0)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (d742fe8) during the generation of this report, so 3a899c0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@nathanjmcdougall nathanjmcdougall merged commit df4da4f into main Apr 8, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/support-overload-in-export-functions branch April 8, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support @overload in export-functions

2 participants