Skip to content

Move test class organization guidance from usethis-python-test-full-coverage to new usethis-python-test skill#1704

Merged
nathanjmcdougall merged 2 commits intocopilot/improve-test-suite-instructionsfrom
copilot/sub-pr-1685
Apr 1, 2026
Merged

Move test class organization guidance from usethis-python-test-full-coverage to new usethis-python-test skill#1704
nathanjmcdougall merged 2 commits intocopilot/improve-test-suite-instructionsfrom
copilot/sub-pr-1685

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

The "Test class organization" section added to usethis-python-test-full-coverage is general test guidance, not coverage-specific. It belongs in its own skill.

Changes

  • Reverted usethis-python-test-full-coverage/SKILL.md to v1.1 — removed the "Test class organization" section; this skill now focuses solely on coverage measurement and verification
  • Created .agents/skills/usethis-python-test/SKILL.md (v1.0) — new skill for general test conventions (class organization, nesting patterns, variant-specific tests, nesting depth, no docstrings); references usethis-python-test-full-coverage for coverage work
  • Registered usethis-python-test in docs/skills-directory.txt and the corresponding sync block in AGENTS.md

…ce out of usethis-python-test-full-coverage

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/0336fce3-623f-4d2d-aad9-ced0c83edf6e

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Revise agent skills organization based on feedback for test class guidelines Move test class organization guidance from usethis-python-test-full-coverage to new usethis-python-test skill Apr 1, 2026
Copilot AI requested a review from nathanjmcdougall April 1, 2026 10:05
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 1, 2026 10:06
@nathanjmcdougall nathanjmcdougall merged commit e2e461d into copilot/improve-test-suite-instructions Apr 1, 2026
11 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/sub-pr-1685 branch April 1, 2026 10:08
nathanjmcdougall added a commit that referenced this pull request Apr 1, 2026
* Initial plan

* Add test class organization guidelines to usethis-python-test-full-coverage skill

Adds a "Test class organization" section covering:
- Top-level classes: one per function or class under test
- Nested classes: group by method, operation, or variant
- Variant-specific tests must be nested inside existing test classes
- Nesting depth guidance (2-3 levels max)
- No docstrings on test classes or functions

Resolves #1645

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/93d2f601-5c64-4f12-8343-b34a2973b558

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

* Move test class organization guidance from usethis-python-test-full-coverage to new usethis-python-test skill (#1704)

* Initial plan

* Create usethis-python-test skill; move test class organization guidance out of usethis-python-test-full-coverage

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/0336fce3-623f-4d2d-aad9-ced0c83edf6e

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants