Add test class organization guidelines to agent skills#1685
Merged
nathanjmcdougall merged 3 commits intomainfrom Apr 1, 2026
Merged
Add test class organization guidelines to agent skills#1685nathanjmcdougall merged 3 commits intomainfrom
nathanjmcdougall merged 3 commits intomainfrom
Conversation
…verage skill Adds a "Test class organization" section covering: - Top-level classes: one per function or class under test - Nested classes: group by method, operation, or variant - Variant-specific tests must be nested inside existing test classes - Nesting depth guidance (2-3 levels max) - No docstrings on test classes or functions Resolves #1645 Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/93d2f601-5c64-4f12-8343-b34a2973b558 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update agent config for better test suite guidance
Add test class organization guidelines to agent skills
Apr 1, 2026
nathanjmcdougall
requested changes
Apr 1, 2026
Contributor
Author
|
@nathanjmcdougall I've opened a new pull request, #1704, to work on those changes. Once the pull request is ready, I'll request review from you. |
…overage to new usethis-python-test skill (#1704) * Initial plan * Create usethis-python-test skill; move test class organization guidance out of usethis-python-test-full-coverage Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/0336fce3-623f-4d2d-aad9-ced0c83edf6e Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
nathanjmcdougall
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents were creating standalone top-level test classes for backend variants (e.g.
TestAddDefaultGroupsPoetry) instead of nesting them inside existing test classes. The agent skills lacked guidance on the project's nested pytest class convention.Added a "Test class organization" section to the
usethis-python-test-full-coverageskill covering:Key convention illustrated: