Skip to content

fix typo in code_evaluator.py#526

Merged
camilamaia merged 2 commits intoscanapi:mainfrom
leonardomaier:524
Feb 18, 2022
Merged

fix typo in code_evaluator.py#526
camilamaia merged 2 commits intoscanapi:mainfrom
leonardomaier:524

Conversation

@leonardomaier
Copy link
Copy Markdown
Contributor

@leonardomaier leonardomaier commented Feb 3, 2022

Description

Fix docstrings typos for CodeEvaluator class.

Motivation behind this PR?

#524

What type of change is this?

Code documentation fix

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #524

@leonardomaier leonardomaier requested review from a team as code owners February 3, 2022 10:38
@leonardomaier leonardomaier mentioned this pull request Feb 3, 2022
Closed
@leonardomaier leonardomaier changed the title docs: fix typo in code_evaluator.py fix typo in code_evaluator.py Feb 3, 2022
@leonardomaier
Copy link
Copy Markdown
Contributor Author

leonardomaier commented Feb 3, 2022

@Pradhvan same problem here with too long lines, looking forward to your response in #523 so I can fix future cases

Pradhvan
Pradhvan approved these changes Feb 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Changes LGTM 👍🏾

@leogregianin can you update the static analysis issue so the static analysis pipeline can pass?

I can also update them too since these aren't directly related to your change, let me know.

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Feb 3, 2022

@leonardomaier I have also invited you to join scanapi on Github. ThankYou for all the efforts. 🙌🏾

@leonardomaier
Copy link
Copy Markdown
Contributor Author

leonardomaier commented Feb 3, 2022

@leonardomaier I have also invited you to join scanapi on Github. ThankYou for all the efforts. 🙌🏾

@Pradhvan Thank you so much! Glad to be part of this amazing project 😄

@leonardomaier
Copy link
Copy Markdown
Contributor Author

leonardomaier commented Feb 3, 2022 •
edited
Loading

@Pradhvan static analysis is still complaining about some unused imports in code_evaluator.py.

Should I remove them? Not sure if these imports (even if not used) are needed for some reason as they are marked with # noqa

@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Feb 3, 2022

@Pradhvan static analysis is still complaining about some unused imports in code_evaluator.py.

Should I remove them? Not sure if these imports (even if not used) are needed for some reason as they are marked with # noqa

I think they are dynamically imported during API Spec that's why they have a comment

# Available imports to be used dynamically in the API spec

#noqa is used to suppress that particular lint complaint. For now, let's leave it as it. I can create an issue later and see how we refactor it to help the static analysis pass.

@camilamaia camilamaia merged commit 4747819 into scanapi:main Feb 18, 2022
camilamaia pushed a commit that referenced this pull request Apr 8, 2022
@leonardomaier @camilamaia
fix: typo in code_evaluator.py (#526)
b4bf619 
* docs: fix typo in code_evaluator.py

* fix: breaks python code regex into multiple lines
astenstrasser pushed a commit that referenced this pull request Apr 14, 2022
@leonardomaier @astenstrasser
fix: typo in code_evaluator.py (#526)
a22a24a 
* docs: fix typo in code_evaluator.py

* fix: breaks python code regex into multiple lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix typos in code_evaluator.py

3 participants

@leonardomaier @Pradhvan @camilamaia