Skip to content

adds missing docstrings to string_evaluator.py#523

Merged
Pradhvan merged 4 commits intoscanapi:mainfrom
leonardomaier:443
Feb 3, 2022
Merged

adds missing docstrings to string_evaluator.py#523
Pradhvan merged 4 commits intoscanapi:mainfrom
leonardomaier:443

Conversation

@leonardomaier
Copy link
Copy Markdown
Contributor

@leonardomaier leonardomaier commented Feb 2, 2022

Description

Updates docstrings for StringEvaluator class.

Motivation behind this PR?

Related to #443

What type of change is this?

Code documentation

Checklist

  • I have added a changelog entry / my PR does not need a new changelog entry. Instructions.
  • I have added/updated unit tests. Instructions.
  • New and existing unit tests pass locally with my changes. Instructions
  • I have self-documented code my changes by adding docstring(s) and comment(s). Instructions
  • Current PR does not significantly decrease the code coverage and docstring coverage.
  • My code follows the style guidelines of this project.
  • I have run ScanAPI locally and manually tested my changes. Instructions.
  • I have squashed my commits. Instructions.

Issue

Closes #443

@leonardomaier leonardomaier requested review from a team as code owners February 2, 2022 11:49
@leonardomaier leonardomaier mentioned this pull request Feb 2, 2022
Closed
@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Feb 2, 2022

@leonardomaier super 🙌🏾 Thank You for the PR. ❤️

Pradhvan
Pradhvan requested changes Feb 2, 2022
View reviewed changes
Comment thread scanapi/evaluators/string_evaluator.py Outdated
@leonardomaier leonardomaier mentioned this pull request Feb 3, 2022
Merged
8 tasks
@leonardomaier
Copy link
Copy Markdown
Contributor Author

leonardomaier commented Feb 3, 2022

@Pradhvan just made the changes 😉

Pradhvan
Pradhvan approved these changes Feb 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@Pradhvan Pradhvan merged commit beff141 into scanapi:main Feb 3, 2022
camilamaia pushed a commit that referenced this pull request Apr 8, 2022
@leonardomaier @camilamaia
docs: adds missing docstrings to string_evaluator.py (#523)
f8fb41f 
* docs: adds missing docstrings in the StringEvaluator class

* fix: breaks variable pattern regex into multiple lines
astenstrasser pushed a commit that referenced this pull request Apr 14, 2022
@leonardomaier @astenstrasser
docs: adds missing docstrings to string_evaluator.py (#523)
0040890 
* docs: adds missing docstrings in the StringEvaluator class

* fix: breaks variable pattern regex into multiple lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the missing docstrings to the string_evaluator.py file

2 participants

@leonardomaier @Pradhvan