Fix PWD capitalization in development setup.#56
Closed
newAM wants to merge 2 commits intopython-kasa:masterfrom
Closed
Fix PWD capitalization in development setup.#56newAM wants to merge 2 commits intopython-kasa:masterfrom
newAM wants to merge 2 commits intopython-kasa:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 70.20% 70.20%
=======================================
Files 9 9
Lines 1094 1094
Branches 157 157
=======================================
Hits 768 768
Misses 305 305
Partials 21 21 Continue to review full report at Codecov.
|
Member
|
Thanks for the PR, but I'll close this as #54 will obsolete requirements* files and remove the dockerfile as it's simple enough to run the tests without docker and avoids the need to maintain the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried the development setup in bash & zsh, both did not handle capital PWD, changing it to lowercase worked.