Skip to content

Convert to use poetry & pyproject.toml for dep & build management#54

Merged
rytilahti merged 8 commits intopython-kasa:masterfrom
rytilahti:refactor/poetry
May 12, 2020
Merged

Convert to use poetry & pyproject.toml for dep & build management#54
rytilahti merged 8 commits intopython-kasa:masterfrom
rytilahti:refactor/poetry

Conversation

@rytilahti
Copy link
Copy Markdown
Member

This gets rid of separately maintained requirements*.txt files and consolidates most of the configs into pyproject.toml file. See https://python-poetry.org/ and https://www.python.org/dev/peps/pep-0518/ for some details.

Linting tests are only on a single target for optimization.

@basnijholt
Copy link
Copy Markdown
Contributor

Cool! The only thing I didn't like with poetry is that you cannot do a development install.

@rytilahti
Copy link
Copy Markdown
Member Author

rytilahti commented May 1, 2020

poetry install does automatically a dev install (inside a virtual env, but that can be disabled with https://python-poetry.org/docs/faq/#i-dont-want-poetry-to-manage-my-virtual-environments-can-i-disable-it).

But I agree that it'd be great to be able to do a simple pip install -e, also.. Generally speaking lot of these are pretty new, and there is some reluctance to support pyproject.toml for global project config (which I find really cool) as there is no toml lib in the stdlib.. mypy and flake8 come to my mind of projects that require a separate configs.

@kirichkov
Copy link
Copy Markdown
Contributor

Do you have any more work on this? If not - go ahead and merge.

@rytilahti
Copy link
Copy Markdown
Member Author

I think it's ready to be merged, in case there's still something to be changed, let's do that in a follow-up PR 🎉

@rytilahti rytilahti merged commit ed57563 into python-kasa:master May 12, 2020
@rytilahti rytilahti deleted the refactor/poetry branch May 12, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update readme Add contribution guidelines and instructions

3 participants