Add support for T100 motion sensor by rytilahti · Pull Request #1079 · python-kasa/python-kasa

rytilahti · 2024-07-23T13:51:00Z

Add support for T100 motion sensor.
Thanks to @DarthSonic for the fixture file!

codecov · 2024-07-23T13:55:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (06ff598) to head (3d37614).
Report is 82 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   92.17%   92.19%   +0.01%     
==========================================
  Files          85       86       +1     
  Lines        5928     5942      +14     
  Branches     1440     1441       +1     
==========================================
+ Hits         5464     5478      +14     
  Misses        358      358              
  Partials      106      106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdb9696 · 2024-07-23T16:43:51Z

+    REQUIRED_COMPONENT = None  # we depend on availability of key
+    REQUIRED_KEY_ON_PARENT = "detected"


Is the key present on the parent hub get_device_info or is it only on the child T100 device_info?

I'd guess it'd only be on the T100 device info. So we should probably either use _check_supported or mark sensitivity as the dependency for this?

Also, given the tests are passing here, I think we need to have some sort of test for this.. :-P

How does it work for the contactsensor which also uses that REQUIRED_KEY_ON_PARENT?

Re tests we should maybe come up with a way to add the children to empty hub devices and pass them in instead of the child device directly.

sdb9696

LGTM once @DarthSonic can confirm it works with his device!

DarthSonic · 2024-07-23T18:14:48Z

LGTM once @DarthSonic can confirm it works with his device!

This is beyond my knowledge of GitHub and python-kasa. Creating the fixture was task enough.

sdb9696 · 2024-07-23T18:27:22Z

This is beyond my knowledge of GitHub and python-kasa. Creating the fixture was task enough.

Hey @DarthSonic, when you created the fixture presumably you installed python-kasa? Did you do it via pip? To install @rytilahti PR just run:

pip3 install "python-kasa[speedups] @ git+https://github.com/python-kasa/python-kasa.git@feat/t100_motion"

Then run:

kasa --host HUB_IP --username YOUR_UN --password YOUR_PW feature motion_detection

You should see the new motion detection item with the current state. Try to trigger some motion and then run the kasa command again to see if it changes.

DarthSonic · 2024-07-23T18:32:48Z

kasa --host HUB_IP --username YOUR_UN --password YOUR_PW feature motion_detection

I only get "Access denied". I am using Windows 11 and need to run "python3 -m ..." commands. I checked out branch with Git GUI for Windows.

sdb9696 · 2024-07-23T18:36:11Z

python3 -m kasa.cli --host HUB_IP --username YOUR_UN --password YOUR_PW feature motion_detection

DarthSonic · 2024-07-23T18:38:19Z

python3 -m kasa.cli --host HUB_IP --username YOUR_UN --password YOUR_PW feature motion_detection

[bold red]No feature by name 'motion_detection'[/bold red]

rytilahti · 2024-07-23T18:40:36Z

Try motion_detected

DarthSonic · 2024-07-23T18:41:50Z

Try motion_detected

Same: [bold red]No feature by name 'motion_detected'[/bold red]

I am on the proper branch I think:

rytilahti · 2024-07-23T18:44:41Z

Yes, that's the correct branch! Try just feature without defining any name, and it will list all available features. I think it doesn't find it as it's a feature of the sensor, and not of the hub.

DarthSonic · 2024-07-23T18:48:50Z

Yes, that's the correct branch! Try just feature without defining any name, and it will list all available features. I think it doesn't find it as it's a feature of the sensor, and not of the hub.

        == Child Katzensensor Wohnzimmer ==

        == Primary features ==
        Motion detected (motion_detected): False

and it updates to "True" if triggered!

rytilahti · 2024-07-24T13:48:17Z

Great, thanks for testing! Let's merge this for the next release :-)

DarthSonic · 2024-07-31T10:18:56Z

@rytilahti Hi. Should this be implemented in Core 2024.7.4 already? If so, I do not see the new motion entity yet.

sdb9696 · 2024-07-31T14:37:11Z

Hi, this is not in the 2024.7.4 release but it should make the 2024.8 beta.

@rytilahti

## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31) [Full Changelog](0.7.0.5...0.7.1) **Release highlights:** - This release consists mainly of bugfixes and project improvements. - There is also new support for Tapo T100 motion sensors. - The CLI now supports child devices on all applicable commands. **Implemented enhancements:** - Expose reboot action [\#1073](#1073) (@rytilahti) - Decrypt KLAP data from PCAP files [\#1041](#1041) (@clstrickland) - Support child devices in all applicable cli commands [\#1020](#1020) (@sdb9696) **Fixed bugs:** - Fix iot light effect brightness [\#1092](#1092) (@sdb9696) - Enable setting brightness with color temp for smart devices [\#1091](#1091) (@sdb9696) - Do not send light\_on value to iot bulb set\_state [\#1090](#1090) (@sdb9696) - Allow erroring modules to recover [\#1080](#1080) (@sdb9696) - Raise KasaException on decryption errors [\#1078](#1078) (@sdb9696) - Update smart request parameter handling [\#1061](#1061) (@sdb9696) - Fix light preset module when list contains lighting effects [\#1048](#1048) (@sdb9696) - Handle module errors more robustly and add query params to light preset and transition [\#1036](#1036) (@sdb9696) - Fix credential hash to return None on empty credentials [\#1029](#1029) (@sdb9696) **Added support for devices:** - Add support for T100 motion sensor [\#1079](#1079) (@rytilahti) **Project maintenance:** - Bump project version to 0.7.0.5 [\#1087](#1087) (@sdb9696) - Fix generate\_supported pre commit to run in venv [\#1085](#1085) (@sdb9696) - Fix intermittently failing decryption error test [\#1082](#1082) (@sdb9696) - Fix mypy pre-commit hook on windows [\#1081](#1081) (@sdb9696) - Update RELEASING.md for patch releases [\#1076](#1076) (@sdb9696) - Use monotonic time for query timing [\#1070](#1070) (@sdb9696) - Fix parse\_pcap\_klap on windows and support default credentials [\#1068](#1068) (@sdb9696) - Add fixture file for KP405 fw 1.0.6 [\#1063](#1063) (@daleye) - Bump project version to 0.7.0.3 [\#1053](#1053) (@sdb9696) - Add KP400\(US\) v1.0.4 fixture [\#1051](#1051) (@gimpy88) - Add new HS220 kasa aes fixture [\#1050](#1050) (@sdb9696) - Add KS205\(US\) v1.1.0 fixture [\#1049](#1049) (@gimpy88) - Add KS200M\(US\) v1.0.11 fixture [\#1047](#1047) (@sdb9696) - Add KS225\(US\) v1.1.0 fixture [\#1046](#1046) (@sdb9696) - Split out main cli module into lazily loaded submodules [\#1039](#1039) (@sdb9696) - Structure cli into a package [\#1038](#1038) (@sdb9696) - Add KP400 v1.0.3 fixture [\#1037](#1037) (@gimpy88) - Add L920\(EU\) v1.1.3 fixture [\#1031](#1031) (@rytilahti) - Update changelog generator config [\#1030](#1030) (@sdb9696)

Add support for T100 motion sensor

5e4e431

rytilahti added the new device New device supported due to fixture being added label Jul 23, 2024

rytilahti added this to the 0.7.1 milestone Jul 23, 2024

sdb9696 reviewed Jul 23, 2024

View reviewed changes

Depend on sensitivity

3d37614

rytilahti mentioned this pull request Jul 23, 2024

TP-Link Smart Home Integration Missing Motion Trigger Entity for T100 Sensor. home-assistant/core#121256

Closed

sdb9696 approved these changes Jul 23, 2024

View reviewed changes

rytilahti merged commit 055bbcc into master Jul 24, 2024

rytilahti deleted the feat/t100_motion branch July 24, 2024 13:48

sdb9696 mentioned this pull request Jul 31, 2024

Prepare 0.7.1 #1094

Merged

rytilahti mentioned this pull request Oct 7, 2024

Add motion detected binary_sensor for tplink home-assistant/core#127883

Merged

19 tasks

		REQUIRED_COMPONENT = None # we depend on availability of key
		REQUIRED_KEY_ON_PARENT = "detected"

Uh oh!

Conversation

rytilahti commented Jul 23, 2024

Uh oh!

codecov Bot commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sdb9696 Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

rytilahti Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdb9696 Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

sdb9696 left a comment

Choose a reason for hiding this comment

Uh oh!

DarthSonic commented Jul 23, 2024

Uh oh!

sdb9696 commented Jul 23, 2024

Uh oh!

DarthSonic commented Jul 23, 2024

Uh oh!

sdb9696 commented Jul 23, 2024

Uh oh!

DarthSonic commented Jul 23, 2024

Uh oh!

rytilahti commented Jul 23, 2024

Uh oh!

DarthSonic commented Jul 23, 2024

Uh oh!

rytilahti commented Jul 23, 2024

Uh oh!

DarthSonic commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rytilahti commented Jul 24, 2024

Uh oh!

DarthSonic commented Jul 31, 2024

Uh oh!

sdb9696 commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 23, 2024 •

edited

Loading

rytilahti Jul 23, 2024 •

edited

Loading

DarthSonic commented Jul 23, 2024 •

edited

Loading