Skip to content

chore: fix tree table icon, update default/glass screenshots - #8285

Merged
jcmill merged 2 commits into
patternfly:mainfrom
mcoker:update-screenshots-4.6.26
Apr 6, 2026
Merged

chore: fix tree table icon, update default/glass screenshots#8285
jcmill merged 2 commits into
patternfly:mainfrom
mcoker:update-screenshots-4.6.26

Conversation

@mcoker

@mcoker mcoker commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #8284

Noticed in this table PR, a tree table icon was updated from ellipsis-h to ellipsis-vertical when that should be ellipsis-horizontal. Fixed that as part of this PR.

default theme report

glass theme report

Summary by CodeRabbit

  • Style
    • Updated the icon displayed for the table details toggle from vertical to horizontal ellipsis design.

@coderabbitai

coderabbitai Bot commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The table details toggle icon template file is updated to render a horizontal ellipsis icon instead of a vertical one by changing the pfIcon identifier from rh-ui-ellipsis-vertical-fill to rh-ui-ellipsis-horizontal-fill.

Changes

Cohort / File(s) Summary
Icon Update
src/patternfly/components/Table/table-details-toggle-icon.hbs		 Changed pfIcon identifier from vertical to horizontal ellipsis icon rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Needs react follow up

Suggested reviewers

  • jcmill
  • srambach
  • lboehling
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commit format with 'chore:' prefix and clearly summarizes the main changes: tree table icon fix and screenshot updates.
Linked Issues check ✅ Passed The PR addresses the linked issue #8284 by updating visual regression screenshots for regular/default and glass themes as required.
Out of Scope Changes check ✅ Passed The tree table icon change (ellipsis icon replacement) is a minimal, focused fix related to the PR objectives and does not introduce unrelated or extraneous changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8285.surge.sh

A11y report: https://pf-pr-8285-a11y.surge.sh

@mcoker
mcoker requested a review from jcmill April 6, 2026 20:18
jcmill
jcmill approved these changes Apr 6, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦

@jcmill
jcmill merged commit 4e48a9c into patternfly:main Apr 6, 2026
5 checks passed
@patternfly-build

patternfly-build commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.66 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request May 1, 2026
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 15, 2026
Closed
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcmill jcmill jcmill approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update visual regression screenshots

3 participants

@mcoker @patternfly-build @jcmill