Skip to content

fix(table): update tokens and icons - #8271

Merged
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:fix/3740-table-glass
Apr 6, 2026
Merged

fix(table): update tokens and icons#8271
mcoker merged 2 commits into
patternfly:mainfrom
jcmill:fix/3740-table-glass

Conversation

@jcmill

@jcmill jcmill commented Apr 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #8233

Summary:

  • Replace striped row background color token with the new --pf-t--global--background--color--striped--row--default token
  • Updated table header button border radius to use --pf-t--global--border--radius--action--plain--default
  • Updated icons to RH branded versions (question mark, ellipsis, and sort indicators)

Summary by CodeRabbit

  • Style
    • Updated table icons and styling for improved visual consistency, including refinements to sort indicators, help actions, details toggles, and striped row appearance.

@jcmill
jcmill requested review from lboehling, mcoker and srambach April 2, 2026 20:03
@coderabbitai

coderabbitai Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b188dfd3-b163-4633-bfbb-99932d6f421b

📥 Commits

Reviewing files that changed from the base of the PR and between 483890b and 81d18ab.

📒 Files selected for processing (4)
  • src/patternfly/components/Table/table-column-help-action.hbs
  • src/patternfly/components/Table/table-details-toggle-icon.hbs
  • src/patternfly/components/Table/table-sort-indicator.hbs
  • src/patternfly/components/Table/table.scss

Walkthrough

This PR updates the Table component to use new design tokens and brand icons. It replaces Font Awesome icon markup with the pfIcon helper, updates button icon references to new brand icons, and revises CSS variables for border-radius and striped row background colors.

Changes

Cohort / File(s) Summary
Table Icon Updates
src/patternfly/components/Table/table-column-help-action.hbs, src/patternfly/components/Table/table-details-toggle-icon.hbs, src/patternfly/components/Table/table-sort-indicator.hbs		 Replaced Font Awesome icon markup and old icon template references with {{pfIcon}} helper calls and new brand icon names (rh-ui-question-mark-circle, rh-ui-ellipsis-vertical-fill, rh-ui-sort-up-small-to-large, rh-ui-sort-down-small-to-large, rh-ui-arrow-up-down).
Table SCSS Variables
src/patternfly/components/Table/table.scss		 Updated CSS variables: button border-radius now uses --pf-t--global--border--radius--action--plain--default and striped row background now uses --pf-t--global--background--color--striped--row--default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • srambach
  • mcoker
  • lboehling
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit guidelines with 'fix' prefix and clearly summarizes the main changes: token and icon updates in the table component.
Linked Issues check ✅ Passed All coding requirements from issue #8233 are met: striped row background token updated, button border radius token updated, and table icons replaced with RH branded versions.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the requirements in issue #8233 with no extraneous modifications detected beyond the specified token and icon updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8271.surge.sh

A11y report: https://pf-pr-8271-a11y.surge.sh

mcoker
mcoker approved these changes Apr 6, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mcoker
mcoker merged commit c9e2dda into patternfly:main Apr 6, 2026
5 checks passed
lboehling
lboehling approved these changes Apr 6, 2026
View reviewed changes

@lboehling lboehling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@patternfly-build

patternfly-build commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.65 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Apr 6, 2026
Merged
Merged
@jcmill
jcmill deleted the fix/3740-table-glass branch May 13, 2026 15:07
@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
Open
This was referenced Jul 22, 2026
Closed
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes
@lboehling lboehling lboehling approved these changes
@srambach srambach Awaiting requested review from srambach

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table: Glass PR Token Followups

4 participants

@jcmill @patternfly-build @mcoker @lboehling