Closed
Conversation
Also fixed a bad #endif position
This was referenced Nov 23, 2022
legendecas
reviewed
Nov 29, 2022
Member
legendecas
left a comment
There was a problem hiding this comment.
Overall LGTM. Thank you for working on this!
Would you mind adding a test that verifies the CleanupHook is available to be used as a class member?
Contributor
Author
@legendecas Added a very simple test, not sure if it is enough |
legendecas
approved these changes
Dec 2, 2022
Member
legendecas
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Member
|
Seems like since the docs do identify the type which is returned it should be public so agree this makes sense. |
mhdawson
pushed a commit
that referenced
this pull request
Dec 2, 2022
PR-URL: #1240 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Also fixed a bad #endif position
Member
|
Landed as 39267ba |
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1240 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Also fixed a bad #endif position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make CleanupHook public.
Added default constructor to make easier store the hook in a member class var.
Also fixed a bad #endif position.
This PR fix issue 1238